Repository navigation
Allow filtering tags in UserTagControl - #38912
Merged
Merged
Conversation
This PR adds `Filter` property to `UserTagControl` which allows overriding the tags which are displayed in it. This is meant to be used in ranked play (as discussed [on](https://discord.com/channels/90072389919997952/1476979671886205060/1525627693490765834) [discord](https://discord.com/channels/90072389919997952/1476979671886205060/1527607201508884633)) to display a prompt allowing players to quickly tag the skillset of the previously played beatmap.
not my best day 🙃
Contributor
|
What is an actual example of the sort of filter that's going to be applied here? It seems like it has to be very exhaustive, because simply setting a filter will cause those tags to always be shown even if they have 0 votes. |
Member
Author
smoogipoo
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds
Filterproperty toUserTagControlwhich allows overriding the tags which are displayed in it. This is meant to be used in ranked play (as discussed on discord) to display a prompt allowing players to quickly tag the skillset of the previously played beatmap.FiltersetEssentially what happens is that all tags matching the filter function are shown, even if they would normally be hidden because of zero votes. Additionally, the 'add new tag' button is hidden, as all tags intended to be available for users are already displayed.