Skip to content

Quizimo_01: Created an AppRouter and formatted the Pages folder, Layout folder - #1

Open
pratyushbh wants to merge 7 commits into
masterfrom
pb_qm_01
Open

pratyushbh wants to merge 7 commits into
masterfrom
pb_qm_01

Conversation

@pratyushbh

@pratyushbh pratyushbh commented Oct 12, 2025 •

Copy link
Copy Markdown
Owner
---
name: Quizimo_01
about: Created an AppRouter and formatted the Pages folder, Layout folder
title: 'Upgrading App Router'
labels: ''
assignees: 'pratyushbh'
---

## Description

Created an AppRouter and formatted the Pages folder, Layout folder, 
->Initially the problem with the router was that to add a route, individual had to create a new route tag after going through the whole app.jsx
-> Also the app.jsx was the only source of truth, in this we can switch the router config or modify it to add/delete/modify routes


## Type of Change

Please check the options that apply:

- [x] New feature
- [ ] Bug fix
- [x] Refactor
- [ ] Enhancement
- [ ] Documentation update
- [ ] Other (please specify):


## Checklist

- [x] My code follows the project's coding style guidelines (ESLint, Prettier).
- [ ] I have added or updated tests to cover my changes.
- [x] I have updated the documentation (if necessary).
- [ ] My changes have been reviewed by at least one other developer.
- [ ] All new and existing tests pass.

## Screenshots/Gifs (if applicable)

Add screenshots or GIFs to illustrate UI changes or new features.

## Additional Notes

Any other information that might be helpful for reviewers.

@pratyushbh pratyushbh self-assigned this Oct 12, 2025
@pratyushbh

Copy link
Copy Markdown
Owner Author

There are some logic that will not make sense as of now like why check for token in local storage for authentication,
I'm planning to improve it but currently we are just using it for placeholder keepsake

@aqsaaqeel aqsaaqeel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general suggestions:

make sure you use consistent exports, if it's default then it should stay throughout
make sure all files have .tsx , if it's jsx then in some situation it gives errors.

Comment thread src/Hoc/AuthVerifier/index.tsx Outdated
Comment on lines +7 to +9
if(isLoggedIn){
navigate('/login');
return null;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this !isLoggedIn

@pratyushbh

Copy link
Copy Markdown
Owner Author

I'm planning to migrate all the files to tsx and use named exports instead of defaults in upcoming PRs, I'll modify the linting rules as I go on too.

@pratyushbh
pratyushbh requested a review from aqsaaqeel October 16, 2025 07:54

@aqsaaqeel aqsaaqeel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise @pratyushbh I would also suggest adding code rabbit to your projects. Has been really helpful for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants