Implement load ndjson files dumped by event listener#67
Open
unidevel wants to merge 2 commits intoprestodb:mainfrom
Open
Implement load ndjson files dumped by event listener#67unidevel wants to merge 2 commits intoprestodb:mainfrom
unidevel wants to merge 2 commits intoprestodb:mainfrom
Conversation
ethanyzhang
force-pushed
the
main
branch
2 times, most recently
from
6f32a1a to
b8de6a7
Compare
Collaborator
|
Hi @unidevel, can you provide an example json? |
Contributor
Author
|
Sure, will update later. |
unidevel
changed the title
unidevel
force-pushed
the
loadeljson
branch
2 times, most recently
from
3704717 to
3063c0c
Compare
unidevel
force-pushed
the
loadeljson
branch
2 times, most recently
from
dab55d0 to
fc418a6
Compare
unidevel
commented
Feb 24, 2026
|
|
||
| func (m *MySQLRunRecorder) Start(_ context.Context, s *Stage) error { | ||
| recordNewRun := `INSERT INTO pbench_runs (run_name, cluster_fqdn, start_time, queries_ran, failed, mismatch, comment) | ||
| recordNewRun := `REPLACE INTO pbench_runs (run_name, cluster_fqdn, start_time, queries_ran, failed, mismatch, comment) |
Contributor
Author
There was a problem hiding this comment.
There is a chance when query failed, it will call event listener twice, thus it can generate the record with same id twice.
unidevel
force-pushed
the
loadeljson
branch
2 times, most recently
from
353e368 to
b0b2434
Compare
Contributor
Author
|
@ethanyzhang can you review again when you get a chance? Thanks. |
ethanyzhang
force-pushed
the
main
branch
2 times, most recently
from
4b003e9 to
0d7d29c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.