-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix(native): Temporarily disable FunctionMetaDataTest.greatest #26742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideTemporarily disables the failing File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Since this test is being disabled due to new signatures, consider either scoping the test to specific signatures or updating the underlying expectations so that the test continues to run rather than being fully disabled.
- It may help future maintainers if you reference a tracking task or differential in the comment explaining why the test is disabled and when it should be re-enabled.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this test is being disabled due to new signatures, consider either scoping the test to specific signatures or updating the underlying expectations so that the test continues to run rather than being fully disabled.
- It may help future maintainers if you reference a tracking task or differential in the comment explaining why the test is disabled and when it should be re-enabled.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary: Test broke due to D87961025 temporarily disable to add new signatures to velox greatest. Differential Revision: D88359540
38ff09b to
3ca1dd1
Compare
|
Did we land the signature in velox? then we can just advance velox and fix the test as well. |
@amitkdutta No, it was blocked since this test was failing internally blocking merging the diff |
Summary: Test broke due to facebookincubator/velox#15666 (D87961025) temporarily disable to add new signatures to
greatest.Differential Revision: D88359540