Skip to content

Conversation

@pratikpugalia
Copy link
Contributor

@pratikpugalia pratikpugalia commented Dec 4, 2025

Summary: Test broke due to facebookincubator/velox#15666 (D87961025) temporarily disable to add new signatures to greatest.

Differential Revision: D88359540

== NO RELEASE NOTE ==

@pratikpugalia pratikpugalia requested review from a team as code owners December 4, 2025 19:23
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 4, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Temporarily disables the failing greatest function metadata test by using GoogleTest's DISABLED_ convention and documents the reason in a comment, without changing any production code.

File-Level Changes

Change Details Files
Temporarily disable the greatest function metadata test to avoid failures while new signatures are being added.
  • Add a comment explaining that the test is disabled due to new signatures being added to the function
  • Rename the greatest test case to DISABLED_greatest using GoogleTest's disabling convention while keeping the test body intact
presto-native-execution/presto_cpp/main/functions/tests/FunctionMetadataTest.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Since this test is being disabled due to new signatures, consider either scoping the test to specific signatures or updating the underlying expectations so that the test continues to run rather than being fully disabled.
  • It may help future maintainers if you reference a tracking task or differential in the comment explaining why the test is disabled and when it should be re-enabled.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since this test is being disabled due to new signatures, consider either scoping the test to specific signatures or updating the underlying expectations so that the test continues to run rather than being fully disabled.
- It may help future maintainers if you reference a tracking task or differential in the comment explaining why the test is disabled and when it should be re-enabled.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Summary:

Test broke due to D87961025 temporarily disable to add new signatures to velox greatest.

Differential Revision: D88359540
@pratikpugalia pratikpugalia changed the title Temporarily disable FunctionMetaDataTest fix(native) : Temporarily disable FunctionMetaDataTest Dec 4, 2025
@pratikpugalia pratikpugalia changed the title fix(native) : Temporarily disable FunctionMetaDataTest fix(native) : Temporarily disable FunctionMetaDataTest.greatest Dec 4, 2025
@pratikpugalia pratikpugalia changed the title fix(native) : Temporarily disable FunctionMetaDataTest.greatest fix(native): Temporarily disable FunctionMetaDataTest.greatest Dec 4, 2025
@amitkdutta
Copy link
Contributor

Did we land the signature in velox? then we can just advance velox and fix the test as well.

@pratikpugalia
Copy link
Contributor Author

Did we land the signature in velox? then we can just advance velox and fix the test as well.

@amitkdutta No, it was blocked since this test was failing internally blocking merging the diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants