-
Notifications
You must be signed in to change notification settings - Fork 863
docs: document removal of --skip-generate and --skip-seed flags in Prisma 7 #7385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: document removal of --skip-generate and --skip-seed flags in Prisma 7 #7385
Conversation
WalkthroughUpdated Prisma 7 migration documentation and CLI reference to reflect the removal of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes These are straightforward documentation updates reflecting API changes. The modifications follow consistent patterns across files—removals paired with consistent warning blocks and guidance text. No code logic, dependencies, or structural changes to review. Possibly related issues
Possibly related PRs
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx (1)
378-383: Tighten command naming + make the “what to run now” steps explicitConsider:
- Using the fully-qualified commands consistently (
prisma migrate dev,prisma db push) instead of “migrate dev/db push” (reduces ambiguity for skimmers).- Adding the explicit follow-up commands inline (e.g., “Run
npx prisma generate” and (for seeding) “Runnpx prisma db seed”), ideally with links to thegenerate/ seeding docs.content/200-orm/500-reference/200-prisma-cli-reference.mdx (1)
1202-1207: Make the replacement action unambiguous (show the exact command)Minor clarity tweak: instead of “Run it explicitly if needed”, consider spelling out the command users should run (e.g., “Run
prisma generateexplicitly if you need updated Prisma Client artifacts afterdb push.”).
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
content/200-orm/500-reference/200-prisma-cli-reference.mdx(2 hunks)content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/400-upgrading-to-prisma-7.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Check internal links
- GitHub Check: Cloudflare Pages
| :::warning | ||
|
|
||
| The `--skip-generate` and `--skip-seed` flags were removed in Prisma 7. `migrate dev` no longer runs `prisma generate` or seeds automatically. Run them explicitly if needed. | ||
|
|
||
| ::: | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix internal inconsistency: migrate dev step list still says it generates artifacts
With this new warning, the earlier numbered list for migrate dev still states it “Triggers the generation of artifacts (for example, Prisma Client)” (Line 1370-1371), which is now contradictory. Please update that step (or add version-conditional wording) so the section is self-consistent.
Deploying docs with
|
| Latest commit: |
c3985dd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://51a05c3b.docs-51g.pages.dev |
| Branch Preview URL: | https://dr-6471-db-push-skip-generat.docs-51g.pages.dev |
…isma 7
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.