refactor(tui): remove client-side derived state, use daemon-computed fields#395
Open
refactor(tui): remove client-side derived state, use daemon-computed fields#395
Conversation
…fields Add alive, alive_known, is_active, and pr_status fields to Run proto. Daemon now computes these values instead of TUI deriving them locally. Remove derive_pr_status() and is_active() method from Python TUI. Simplify elapsed_time() to use daemon-provided elapsed_display. Closes orch-392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alive,alive_known,is_active, andpr_statusfields to Run proto messagederive_pr_status()function andis_active()method from Python TUIelapsed_time()to use daemon-providedelapsed_displayChanges
Proto Schema (
api/orch.proto)Runmessage:alive,alive_known,is_active,pr_statusGo Daemon (
internal/daemon/proto_handler.go)protoIsActiveStatus()to compute active state from statuscomputePRStatus()to derive PR status from run statecomputeAliveStatus()to check agent liveness via multiplexerPython TUI
is_active()method, simplifiedelapsed_time()derive_pr_status(), userun.pr_statusdirectlyTesting
hymodule issue)Closes orch-392