Skip to content

Make CapturePreferences only keep track of changes #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catilac merged 1 commit into from
Jan 16, 2026
+4 −5
Merged

Make CapturePreferences only keep track of changes #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions app/src/processing/app/ui/PDEPreferences.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ private val LocalModifiablePreferences =
compositionLocalOf { ModifiablePreference(null, false, { }, {}) }

/**
* Composable function that provides a modifiable copy of the current preferences.
* Composable function that captures an initial copy of the current preferences.
* This allows for temporary changes to preferences that can be reset or applied later.
*
* @param content The composable content that will have access to the modifiable preferences.
Expand Down Expand Up @@ -498,13 +498,13 @@ private fun CapturePreferences(content: @Composable () -> Unit) {
}

val apply = {
modified.entries.forEach { (key, value) ->
prefs.setProperty(key as String, (value ?: "") as String)
prefs.entries.forEach { (key, value) ->
modified.setProperty(key as String, (value ?: "") as String)
}
}
val reset = {
modified.entries.forEach { (key, value) ->
modified.setProperty(key as String, prefs[key] ?: "")
prefs.setProperty(key as String, modified[key] ?: "")
}
}
val state = ModifiablePreference(
Expand All @@ -515,7 +515,6 @@ private fun CapturePreferences(content: @Composable () -> Unit) {
)

CompositionLocalProvider(
LocalPreferences provides modified,
LocalModifiablePreferences provides state
) {
content()
Expand Down