Update Composed device type tag logic

[AryaHassanli]

Composed Device Type in datamodel XMLs contained redundant information about cluster requirements that were already present in <clusters> tags under device type XMLs.

This PR updates the rendering logic to keep cluster requirements under and introduce "Device Type Requirements" under composed device types.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the rendering logic for composed device types in datamodel XMLs to address redundancy and improve structural clarity. It introduces a dedicated mechanism for handling device-specific requirements, distinct from cluster requirements. This change ensures that the generated XML output accurately reflects the intended separation of concerns, making the data model more precise and maintainable.

Highlights

• Data Model Structure: Introduced a new deviceRequirements field within the deviceTypeRequirements struct to explicitly handle device type specific requirements, separating them from cluster requirements.
• XML Rendering Logic: Updated the rendering logic for composedDeviceTypes to correctly process and include DeviceTypeRequirements elements, ensuring proper XML output for device-specific constraints and conformance.
• Redundancy Removal: Eliminated redundant rendering of cluster requirements directly under composedDeviceTypes, aligning with the goal of keeping cluster requirements under their dedicated <clusters> tags.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the rendering logic for composed device types, introducing a new "Device Type Requirements" section and removing redundant cluster requirement information. The changes are generally well-implemented, but I've identified a potential bug where multiple device requirements for the same device type are not correctly aggregated, leading to some requirements being ignored. I've provided a code suggestion to address this by combining all conformances and constraints. The rest of the refactoring, including the code removal, appears correct and improves the structure.