Skip to content

Additional errata features#53

Merged
AryaHassanli merged 6 commits intoproject-chip:mainfrom
AryaHassanli:additional-errata-features
Mar 25, 2026
Merged

Additional errata features#53
AryaHassanli merged 6 commits intoproject-chip:mainfrom
AryaHassanli:additional-errata-features

Conversation

@AryaHassanli
Copy link
Copy Markdown
Contributor

@AryaHassanli AryaHassanli commented Mar 25, 2026

Highlights

  • Extended Errata SDKType: The SDKType struct in errata/sdk.go now includes a Response field, enabling more detailed errata definitions for command responses.
  • Conformance Resolution Exported and Enhanced: The resolveConformances function in matter/spec/conformance.go was exported as ResolveConformances and a new Specification.ResolveConformances method was added, making conformance resolution more accessible.
  • Bitmap Conformance Overrides: A SetConformance method was added to the Bit interface and BitmapBit implementation, allowing errata to override conformance for bitmap bits.
  • Expanded Errata Application: The ApplyErrata function in sdk/errata.go now calls the new spec.ResolveConformances() and supports overriding Response for commands and FabricScoping and FabricSensitivity for events.
  • Improved Field Overrides: The applyErrataToField function in sdk/struct.go was updated to correctly handle list data types for OverrideType and to allow direct assignment of a field's ID via a Value override.

Spec PR to update Errata header: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/12835

@AryaHassanli AryaHassanli requested a review from a team as a code owner March 25, 2026 18:16
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the errata system by introducing new override capabilities and improving conformance resolution. It allows for more granular control over command responses, event fabric scoping, and bitmap conformance through errata definitions. These changes streamline the process of applying corrections and customizations to the SDK's data structures and behaviors.

Highlights

  • Extended Errata SDKType: The SDKType struct in errata/sdk.go now includes a Response field, enabling more detailed errata definitions for command responses.
  • Conformance Resolution Exported and Enhanced: The resolveConformances function in matter/spec/conformance.go was exported as ResolveConformances and a new Specification.ResolveConformances method was added, making conformance resolution more accessible.
  • Bitmap Conformance Overrides: A SetConformance method was added to the Bit interface and BitmapBit implementation, allowing errata to override conformance for bitmap bits.
  • Expanded Errata Application: The ApplyErrata function in sdk/errata.go now calls the new spec.ResolveConformances() and supports overriding Response for commands and FabricScoping for events.
  • Improved Field Overrides: The applyErrataToField function in sdk/struct.go was updated to correctly handle list data types for OverrideType and to allow direct assignment of a field's ID via a Value override.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the Matter specification SDK by improving errata application and conformance resolution. Key changes include refactoring and exposing conformance resolution, adding support for setting conformance on bitmap bits via errata, extending errata to override command responses and event fabric scoping, and refining field type parsing to correctly handle list types and field ID overrides. There are no review comments to address.

@AryaHassanli AryaHassanli merged commit 2127752 into project-chip:main Mar 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant