Integrate NXP MCU missing changes in v1.5-branch #42289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request integrates a number of changes for the NXP MCU platform, including bug fixes, documentation updates, and a significant refactoring to remove the GN build system for many examples in favor of CMake. Key changes include correcting memory leaks, improving the robustness of multi-part AEAD operations, fixing network status change notifications, and enhancing the wifi connect shell command. The changes are generally of high quality and improve the stability and usability of the NXP platform. I have a few minor suggestions for improving documentation clarity and code comments.
|
PR #42289: Size comparison from c8840de to b054788 Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Allow selecting extra gatt db header without depending on other config options. Allow deriving the base lock app AppTask and DeviceCallbacks classes. Signed-off-by: Marius Preda <[email protected]>
…mware processor (project-chip#41944) Using function local static state variables such as "ulCrtAddr" and "ulEraseLen" in the OTAFirmwareProcessor::ProcessInternal method causes issues when OTA transfers are interrupted and then resumed because the function local variables cannot be accessed (and reset) by other class methods (such as OTAFirmwareProcessor::Clear or OTAFirmwareProcessor::AbortAction). The use of function local state variables was dropped and the SDK wireless framework OTA support layer is now in charge of managing block addresses and erases. Reviewed-by: Dina Benamar <[email protected]> Signed-off-by: Marian Chereji <[email protected]>
…p#41910) * [nxp][doc][examples][mcxw71] Restructure platform documentation Signed-off-by: Marian Chereji <[email protected]> * [nxp][doc][examples][mcxw72] Restructure platform documentation Signed-off-by: Marian Chereji <[email protected]> * [nxp][cmake][platform][mcxw7x] Remove unused ICD build options Removed the build options o CONFIG_CHIP_ICD_IDLE_MODE_INTERVAL_MS o CONFIG_CHIP_ICD_ACTIVE_MODE_INTERVAL_MS which don't seem to be used anywhere. They were most likely leftovers after replacement with o CHIP_ICD_IDLE_MODE_DURATION o CHIP_ICD_ACTIVE_MODE_DURATION Signed-off-by: Marian Chereji <[email protected]> --------- Signed-off-by: Marian Chereji <[email protected]>
* [NXP] Fix DnssdImplBr handling of SRP cache resolve This commit fixes the case where a service query is resolved directly from the SRP cache on a Border Router. In this case there is no need to add the context to the list and start the OT mMDNS client. Signed-off-by: Marius Preda <[email protected]> * Restyled by clang-format * [NXP] Added comment to HandleResolveCleanup Signed-off-by: Marius Preda <[email protected]> * Restyled by whitespace --------- Signed-off-by: Marius Preda <[email protected]> Co-authored-by: Restyled.io <[email protected]>
… one hour (project-chip#41993) For Long Idle Time ICDs the idle mode duration may be several hours or even longer. Reviewed-by: Marian Chereji <[email protected]> Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Andrei Menzopol <[email protected]>
…for ethernet and wifi (project-chip#42031) * [NXP][wifi] Fix read last-networking-status and read last-network-id issue Signed-off-by: Martin Girardot <[email protected]> * [NXP][ethernet] Fix read last-networking-status and read last-network-id issue Signed-off-by: Martin Girardot <[email protected]> * [NXP] fix PR comment Signed-off-by: Martin Girardot <[email protected]> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Martin Girardot <[email protected]> Co-authored-by: Restyled.io <[email protected]>
…ng updates in short time (project-chip#42032) Signed-off-by: Martin Girardot <[email protected]>
…onnection during revert config (project-chip#42064) Signed-off-by: Martin Girardot <[email protected]>
…al application support for the MCXW72 and RW61X platforms (project-chip#41060) * [NXP] Deprecating GN build support for NXP MCUs, retaining only minimal application support for the MCXW72 and RW61X platforms Signed-off-by: Gatien Chapon <[email protected]> * Restyling + fix readme bad references Signed-off-by: Gatien Chapon <[email protected]> * Removing cmake option for nxp build from all_targets_linux_x64.txt Signed-off-by: Gatien Chapon <[email protected]> * Updating documentation to remove cmake arg when build NXP freeRTOS example using build_example.py script Signed-off-by: Gatien Chapon <[email protected]> --------- Signed-off-by: Gatien Chapon <[email protected]>
* [nxp][platform][common] Add App nvm keys to NXPConfig * Add App keys to be used for custom application nvm values set at runtime. * Add App OTA done key. * Update ValidConfigKey to account for new keys. Signed-off-by: Andrei Menzopol <[email protected]> * [nxp][platform][mcxw71] Add App nvm keys to K32W1Config * Add App keys to be used for custom application nvm values set at runtime. * Add App OTA done key. * Update ValidConfigKey to account for new keys. Signed-off-by: Andrei Menzopol <[email protected]> * [nxp][platform][mcxw7x] Update DetermineBootReason for successful OTA * Add read/write ota done nvm key in order to set kSoftwareUpdateCompleted boot reason. Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format * [nxp][platform][mcxw71] Resolve conversations * Added more specific messages * Don't return error when read doesn't find key * Return error when failing to write Signed-off-by: Andrei Menzopol <[email protected]> * [nxp][platform][mcxw71] Minimize usage of err in ConfigurationManagerImpl Signed-off-by: Andrei Menzopol <[email protected]> * Restyled by clang-format --------- Signed-off-by: Andrei Menzopol <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* [NXP] allow user to connect devices to open network Signed-off-by: Martin Girardot <[email protected]> * Restyled by whitespace * Restyled by clang-format * [NXP] Fix PR comment Signed-off-by: Martin Girardot <[email protected]> --------- Signed-off-by: Martin Girardot <[email protected]> Co-authored-by: Restyled.io <[email protected]>
… simple test event trigger delegate (project-chip#42133) * [NXP][example_common] Adding a dedicated KCONFIG option to register a simple test event trigger delegate Signed-off-by: Oliver Fan <[email protected]> * Update examples/platform/nxp/common/app_task/source/AppTaskBase.cpp Co-authored-by: Gatien Chapon <[email protected]> --------- Signed-off-by: Oliver Fan <[email protected]> Co-authored-by: Gatien Chapon <[email protected]>
Signed-off-by: Doru-Cristian Gucea <[email protected]>
…tion layer to make it reusable across multiple Zephyr-based platforms (project-chip#42198) * [Zephyr][platform] Update the generic Zephyr platform adaptation layer to be reusable by other zephyr platforms * Adding wifi to the BUILD.gn file to support building matter-over-wifi * Adding support of wifi in the ConnectivityManagerImpl * Adding DeviceInstanceInfoProviderImpl * Adding CHIP macro config mapping with Kconfig to ease platform overrides Signed-off-by: Dina Benamar <[email protected]> * [Zephyr][platform][config] Adding Kconfig definitions to the generic config/zephyr/Kconfig * Kconfig added to the generic layer, to allow platforms to reuse the src/platform/Zephyr and override the CHIP configs easily per platform * CONFIG_CHIP_LOG_SIZE_OPTIMIZATION moved from the platform layer definition to the generic zephyr Kconfig, to allow its use in src/platform/Zephyr, and reduce duplicatio * note that the default can still be overridden per platform Signed-off-by: Dina Benamar <[email protected]> * [Zephyr][platform][config] Adding Kconfig to configure the chip task priority, stack sze and event queue size + Adding Kconfig for MRP local retry intervals (active & idle) Signed-off-by: Dina Benamar <[email protected]> * Update src/platform/Zephyr/DeviceInstanceInfoProviderImpl.h line ending to support restyle patch Signed-off-by: Dina Benamar <[email protected]> * Restyled by whitespace * Restyled by clang-format --------- Signed-off-by: Dina Benamar <[email protected]> Co-authored-by: Restyled.io <[email protected]>
dinabenamar
approved these changes
Dec 9, 2025
andy31415
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picking NXP MCU Matter platform fixes to v1.5-branch
Related issues
Testing
No test. Testing was already performed when initial PRs were created
Cherry-pick list
[NXP] Allow extra customization of default lock app (project-chip#41843)
cherry-pick from 515eed118c
[NXP][platform][common] Avoid using static state variables in OTA firmware processor (project-chip#41944)
cherry-pick from 7a6eddd379
[NXP][doc][mcxw7x] Update MCXW7x platforms documentation (project-chip#41910)
cherry-pick from 4915fb0953
[NXP] Fix DnssdImplBr handling of SRP cache resolve (project-chip#41848)
cherry-pick from 053c954186
[nxp][cmake][platform][mcxw7x] Increase LIT ICD idle mode duration to one hour (project-chip#41993)
cherry-pick from aa80cc7ca2
[NXP] Fix read last-networking-status and read last-network-id issue for ethernet and wifi (project-chip#42031)
cherry-pick from b335217df4
[NXP][wifi-otbr] fix TC-CGEN-2.2 issue due to multiple mdns advertising updates in short time (project-chip#42032)
cherry-pick from d345d51cc1
[NXP] Fix TC-CGEN-2.4 and TC-CGEN-2.2 issue due to unnecessary wifi connection during revert config (project-chip#42064)
cherry-pick from d975aafe3c
[NXP] Deprecating GN build support for NXP MCUs, retaining only minimal application support for the MCXW72 and RW61X platforms (project-chip#41060)
cherry-pick from 74647d1518
[NXP] Fix BootReason for successful OTA (project-chip#41957)
cherry-pick from 9bf202b320
[NXP] allow user to connect devices to open network (project-chip#42138)
cherry-pick from 318d81e088
[NXP][example_common] Adding a dedicated KCONFIG option to register a simple test event trigger delegate (project-chip#42133)
cherry-pick from 67d831e4fb
psa: fix buffer overflow (project-chip#42015)
cherry-pick from fe7d07a904
[Zephyr][platform][config] Update the existing Zephyr platform adaptation layer to make it reusable across multiple Zephyr-based platforms (project-chip#42198)
cherry-pick from 8dd3e202bd