Upgrade to LLVM 23.1.0 by tim-hoffman · Pull Request #722 · project-llzk/llzk-lib

tim-hoffman · 2026-09-10T19:00:48Z

See changelog and additional explanations in diff comments.

tim-hoffman · 2026-09-28T13:26:28Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef159730c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

tim-hoffman · 2026-09-28T18:00:00Z

-  let parameters = (ins APIntParameter<"felt constant value">:$value);
+  let parameters =
+      (ins WidthInsensitiveAPIntParameter<"felt constant value">:$value);


MLIR added APIntParameter so the LLZK version changed to WidthInsensitiveAPIntParameter to preserve the width-insensitive semantics the LLZK version had.

tim-hoffman · 2026-09-28T18:00:46Z

  let name = "pcl";
  let summary = "PCL";
  let cppNamespace = "::pcl";
-  let usePropertiesForAttributes = 0;


MLIR removed this option (it was previously deprecated).

tim-hoffman · 2026-09-28T18:01:43Z

    auto lhs = adaptor.getTrueValue();
    auto rhs = adaptor.getFalseValue();
-    Value temp = rewriter.create<pcl::VarOp>(location, *tempName, /*public=*/false);
+    Value temp = pcl::VarOp::create(rewriter, location, *tempName, /*public=*/false);


This is the most common change, builder.create<Type>(...) was replaced with Type::create(builder,...).

tim-hoffman · 2026-09-28T18:07:00Z

  ) const override;
 };

+/// Lower felt negation to upstream SMT subtraction from an explicit zero.


Generate smt.int.sub 0, x in place of deleted smt.int.neg

tim-hoffman · 2026-09-28T18:09:41Z

-    static Edge getEmptyKey() { return Edge(nullptr, BaseInfo::getEmptyKey()); }
-    static Edge getTombstoneKey() { return Edge(nullptr, BaseInfo::getTombstoneKey()); }


The upstream DenseMap implementation no longer requires these.

tim-hoffman · 2026-09-28T18:12:36Z

  let results = (outs I1:$result);
  let assemblyFormat = [{
-    `` $predicate `(` $lhs `,` $rhs `)`
+    $predicate `(` $lhs `,` $rhs `)`


This previously avoided printing a space at the start but some printer upstream has changed so the space here is now necessary to print bool.cmp ne instead of incorrectly printing bool.cmpne.

tim-hoffman · 2026-09-28T18:13:22Z

 /// Memory resource indicating a `global.def` memory resource.
 struct GlobalMemoryResource : public mlir::SideEffects::Resource::Base<GlobalMemoryResource> {
-  mlir::StringRef getName() final;
+  mlir::StringRef getName() const final;


Upstream API now uses const

tim-hoffman · 2026-09-28T18:14:00Z

-
-// APInts whose bitwidth is part of their identity. Check it before operator==,
-// which requires equal widths.
-class WidthSensitiveAPIntParameter<string desc = "">


Width-sensitive version is now the upstream APIntParameter

tim-hoffman · 2026-09-28T18:17:24Z

-/// Verify that the operation has a parent of type `op` somewhere in its
-/// ancestry.
-class HasAncestor<string op> : ParamNativeOpTrait<"HasAncestor", op>,
-                               StructuralOpTrait {
-  string cppNamespace = "::llzk";
-}
-
-/// Verify that the operation has a parent of one of the `ops` types somewhere
-/// in its ancestry.
-class HasAncestorOf<list<string> ops>
-    : ParamNativeOpTrait<"HasAncestor", !interleave(ops, ", ")>,
-      StructuralOpTrait {
-  string cppNamespace = "::llzk";
-}
-


Now available upstream as HasAncestor and AncestorOneOf

tim-hoffman · 2026-09-28T18:29:50Z

+      // Per-call argument and result attribute dictionaries required by
+      // CallOpInterface.
+      OptionalAttr<DictArrayAttr>:$arg_attrs,
+      OptionalAttr<DictArrayAttr>:$res_attrs);


Required by CallOpInterface and were previously auto-generated in older LLVM version.

tim-hoffman · 2026-09-28T18:33:26Z

+  void getDependentDialects(DialectRegistry &registry) const override {
+    auto nestedPM = createPostScalarizationPipeline();
+    nestedPM.getDependentDialects(registry);
+  }


The refactoring in this file was done to add this function override which is necessary to ensure all dialects needed by the pass are loaded before the pass runs.

tim-hoffman · 2026-09-28T18:36:19Z

-/// For each Type in the given input collection, call `splitPodArrayTypeTo(Type,...)`.
-template <typename TypeCollection>
-void splitPodArrayTypeTo(
-    TypeCollection types, SmallVectorImpl<Type> &collect, SmallVector<size_t> *originalIdxToSize
-) {
-  for (Type t : types) {
-    size_t count = splitPodArrayTypeTo(t, collect);
-    if (originalIdxToSize) {
-      originalIdxToSize->push_back(count);
-    }
-  }
-}
-


tim-hoffman · 2026-09-28T18:45:19Z

-// CHECK-NEXT:    <@TA::@A::@compute>:%self = struct.new : <@TA::@A<[@Start, @Stop, @Step]>> predecessors:
-// CHECK-NEXT:        <(no parent function op)>:function.def @compute(%arg0: !felt.type) -> !struct.type<@TA::@A<[@Start, @Stop, @Step]>> attributes {function.allow_witness} {...}
-// CHECK-NEXT:    <@TA::@A::@compute>:%array = array.new  : <4 x !felt.type> predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%self = struct.new : <@TA::@A<[@Start, @Stop, @Step]>>
-// CHECK-NEXT:    <@TA::@A::@compute>:%c0 = arith.constant 0 : index predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%array = array.new  : <4 x !felt.type>
-// CHECK-NEXT:    <@TA::@A::@compute>:%c1 = arith.constant 1 : index predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%c0 = arith.constant 0 : index
-// CHECK-NEXT:    <@TA::@A::@compute>:%c4 = arith.constant 4 : index predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%c1 = arith.constant 1 : index
-// CHECK-NEXT:    <@TA::@A::@compute>:%0 = poly.read_const @Start : index predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%c4 = arith.constant 4 : index
-// CHECK-NEXT:    <@TA::@A::@compute>:%1 = poly.read_const @Stop : index predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%0 = poly.read_const @Start : index
-// CHECK-NEXT:    <@TA::@A::@compute>:%2 = poly.read_const @Step : index predecessors:
-// CHECK-NEXT:        <@TA::@A::@compute>:%1 = poly.read_const @Stop : index


This was moved below verbatim due to internal data structure change

tim-hoffman · 2026-09-28T18:46:08Z

 //CHECK-LABEL: ---- SymbolUseGraph ----
 //CHECK-NEXT:  - Node : [0x[[R01:[0-9a-f]+]]] '@HasUse::@compute' with root module @"<<symbol lookup root>>"
-//CHECK-NEXT:  --- loc("within split at {{.*}}symbol_use_graph_pass.llzk:1 offset ":8:5)
+//CHECK-NEXT:  --- loc("{{.*}}symbol_use_graph_pass.llzk":8:5)


Upstream changed the location description for -split-input-file inputs

tim-hoffman · 2026-09-28T18:49:37Z

-// CHECK-NEXT:      function.def private @sink()
+// CHECK-NEXT:      function.def @sink() {
+// CHECK-NEXT:        function.return
+// CHECK-NEXT:      }


It didn't like this def without a body anymore but that wasn't the point of the test anyway so I changed it. That causes the removal of 2 lines below due to the empty body now being inlined.

This reverts commit 80ef0af.

tim-hoffman · 2026-09-28T21:30:04Z

@@ -1,4 +1,5 @@
 // RUN: llzk-opt -split-input-file -llzk-pod-to-scalar -verify-diagnostics %s
+// XFAIL:*


The improved RDV pass (run independently without pod-to-scalar) now deletes the loop carried pods in most of these cases (all but the first), thus bypassing the original purpose of the tests.

#759 also affects several of the tests in this file

tim-hoffman · 2026-09-28T21:34:19Z

@@ -1,4 +1,5 @@
 // RUN: llzk-opt -split-input-file -llzk-pod-to-scalar -verify-diagnostics %s
+// XFAIL:*


The improved RDV pass (run independently without pod-to-scalar) now deletes the loop carried pods in each of these cases, thus bypassing the original purpose of the test.

shankarapailoor

LGTM

tim-hoffman added 30 commits September 8, 2026 13:15

TEMP: use llzk-nix-pkgs PR branch

80ef0af

run nix flake update

ec4c4a3

Update LLVM version numbers

d8d59c3

update manual build instructions/script

046c2e0

update per tablegen EnumAttr refactoring

4a1830a

Update per addition of APIntParameter to upstream

bf46109

remove outdated options

a102ba7

update tablegen diagnostics API use

73df9d5

add explicit comparator as required

a2f4f14

remove redundant HasAncestor

d2ab67c

replace hasParentThatIsa with updated getParentOfType API

bd42945

update builder.create API usage

1775938

adjust for SideEffects API change

54ddf4c

update per arith::ConstantIntOp API change

ab9d07d

formatting

2b906ef

ported smt dialect disambiguation and API fixes

9ab717e

fix SymbolTableCollection cannot be moved anymore

6d6e65d

remove deprecated llvm::make_scope_exit

7f90379

Add explicit arg_attrs and res_attrs that were missing

94c235d

fix: DenseMap no longer uses empty/tombstone

51c30a8

fix inlineCall API usage

fa93f42

fix constantTripCount API usage

5945e47

use updated post-order traversal API

8f3a936

fix EquivalenceClasses API usage

14849f7

update call/function helper API usage

4b5b570

fix SparseAnalysis API

7700f4f

adjust to GreedyRewriteConfig API change

0db16bc

remove outdated API usage

8ea9165

fix ReturnOp builder

b427ad3

fix pass registration function naming

d98c94e

tim-hoffman requested a review from a team as a code owner September 28, 2026 13:26

chatgpt-codex-connector Bot reviewed Sep 28, 2026

View reviewed changes

Comment thread include/llzk/Dialect/SMTInfo/IR/CMakeLists.txt

Comment thread CMakeLists.txt Outdated

tim-hoffman added 2 commits September 28, 2026 10:44

fix smt dialect documentation

d2fb713

fix: Quote list-valued include generator expressions

5ceeb7c

tim-hoffman commented Sep 28, 2026

View reviewed changes

update changelog

006b86d

tim-hoffman commented Sep 28, 2026

View reviewed changes

Remove outdated clang-tidy suppressions

3ac696a

tim-hoffman commented Sep 28, 2026

View reviewed changes

tim-hoffman added 3 commits September 28, 2026 14:07

Revert "TEMP: use llzk-nix-pkgs PR branch"

9f0f1d8

This reverts commit 80ef0af.

run nix flake update

7d38472

fix: replace poison with nondet

1ce6e48

tim-hoffman commented Sep 28, 2026

View reviewed changes

shankarapailoor approved these changes Sep 29, 2026

View reviewed changes

tim-hoffman merged commit 8cc9ef9 into main Sep 29, 2026
10 checks passed

tim-hoffman deleted the th/llvm23 branch September 29, 2026 13:07

		static Edge getEmptyKey() { return Edge(nullptr, BaseInfo::getEmptyKey()); }
		static Edge getTombstoneKey() { return Edge(nullptr, BaseInfo::getTombstoneKey()); }

		@@ -1,4 +1,5 @@
		// RUN: llzk-opt -split-input-file -llzk-pod-to-scalar -verify-diagnostics %s
		// XFAIL:*

Conversation

tim-hoffman commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tim-hoffman commented Sep 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tim-hoffman Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shankarapailoor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tim-hoffman commented Sep 10, 2026 •

edited

Loading

tim-hoffman Sep 28, 2026 •

edited

Loading