Repository navigation
Update tests that don't need to XFAIL - #756
Merged
Merged
Conversation
tim-hoffman
requested
a balanced review from Copilot
and removed request for
a team
September 23, 2026 00:31
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The passing column-field test retains a misleading _xfail filename.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates two transformation tests to remove obsolete XFAILs and verify successful flattening output.
Changes:
- Removes XFAIL directives.
- Adds or refreshes FileCheck expectations.
- Adds constant-global propagation coverage.
| File | Description |
|---|---|
test/Transforms/PlaceholderSanity/placeholder_in_source.llzk |
Enables and verifies placeholder flattening. |
test/Transforms/Flattening/instantiate_column_field_xfail.llzk |
Converts global-offset column-field scenarios into passing checks; the stale _xfail filename must be renamed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Test Results 2 files ±0 2 suites ±0 3m 5s ⏱️ +47s Results for commit 37e3b1c. ± Comparison against base commit 24250ae. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.