Make generate protobuf script compatible with mac #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay DeLuca <[email protected]>
Signed-off-by: Jay DeLuca <[email protected]>
jaydeluca
commented
Feb 6, 2026
| [tasks.generate] | ||
| description = "bare compile, ignoring formatting and linters" | ||
| run = [ | ||
| "mise use --pin protoc@latest", |
Collaborator
Author
There was a problem hiding this comment.
this caused me a lot of confusion because my local mise wasn't up to date, so it kept downgrading the version and then generating code that broke the build. I think the versions are updated by renovate so i dont think this is needed?
Member
There was a problem hiding this comment.
I think I had the issue once that the releases were spread apart and renovate didn't group them. Happy to remove it if helps avoid confusion.
Signed-off-by: Jay DeLuca <[email protected]>
zeitlinger
reviewed
Feb 9, 2026
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
We also have other approaches:
- Use python, which doesn't have this problem and is probably easier to read as well
- Use a GH action to check out the
renovate/protobuf-monorepobranch and run the generate command
Both 1 and 2 is also a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.