Open
Conversation
Signed-off-by: sh0rez <me@shorez.de>
Signed-off-by: sh0rez <me@shorez.de>
mxinden
reviewed
Feb 7, 2022
Member
mxinden
left a comment
There was a problem hiding this comment.
Thanks for providing a patch!
Would you mind adding a changelog entry? Something along the lines of:
## [0.15.2] - unreleased
### Added
- Support for `f32` `Gauge` and `Counter`. See [PR xx].
- Support for `xtensa` architecture. See [PR xx].
And bump the patch version in Cargo.toml?
Also does Rust support cross compilation for xtensa? If so, want to add it to the matrix in our CI config?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library already works really well on the embedded ESP32 SOC, but that platform being 32-bit means we cannot use
AtomicU32.This PR adds
xtensato the list of 32-bit architectures, so that it compiles.It also implements
Atomicforf32, so that Gauges become usable.IMHO we really should use rust-lang/rust#32976 once available, but that is for another day.