proposal: add proposal for issue/PR label convention#65
Open
jan--f wants to merge 4 commits intoprometheus:mainfrom
Open
proposal: add proposal for issue/PR label convention#65jan--f wants to merge 4 commits intoprometheus:mainfrom
jan--f wants to merge 4 commits intoprometheus:mainfrom
Conversation
jan--f
changed the title
jan--f
force-pushed
the
issue-pr-labels
branch
from
79b6366 to
6f7c5a7
Compare
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
issue-pr-labels
branch
from
6f7c5a7 to
86fd9cc
Compare
beorn7
reviewed
Nov 15, 2025
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Looks good to me in general. However, I also don't feel very strongly about the details here. I guess once we see in in practice, we will see what works well and what needs changes. We shouldn't shy away from cutting out unused parts later. We have way too much label cruft already.
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
issue-pr-labels
branch
from
8c23d92 to
6aec48f
Compare
beorn7
requested changes
Dec 17, 2025
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Two smallish comments left.
In doubt, I would just go forward with this. We can always iterate on it.
In any case, it would be great if somebody else would look at this.
jan--f
force-pushed
the
issue-pr-labels
branch
from
64c33f8 to
e97d357
Compare
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
issue-pr-labels
branch
from
e97d357 to
a3a38b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.