Add the Yields() conformance matcher that reports results to the TestManager. - #30281
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_984198662
branch
3 times, most recently
from
October 3, 2026 20:09
12ac355 to
10d2974
Compare
…Manager. Every gtest-based conformance test ends in EXPECT_THAT(result, Yields(m)). The leaf matchers stay pure, and Yields() is the one place with side effects. It reports the outcome to the TestManager once per test and turns the failure list into the gtest verdict, so a listed failure passes and an unexpected success fails. A listed test the testee skips fails, which is stricter than the old runner. The matchers find the TestManager through GetGlobalTestManager(), which is declared here and defined by the conformance binary or by the matchers' own unit test. PiperOrigin-RevId: 984198662
copybara-service
Bot
force-pushed
the
test_984198662
branch
from
October 3, 2026 20:28
10d2974 to
b63aa36
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Yields() conformance matcher that reports results to the TestManager.
Every gtest-based conformance test ends in EXPECT_THAT(result, Yields(m)).
The leaf matchers stay pure, and Yields() is the one place with side
effects. It reports the outcome to the TestManager once per test and
turns the failure list into the gtest verdict, so a listed failure passes
and an unexpected success fails. A listed test the testee skips fails,
which is stricter than the old runner.
The matchers find the TestManager through GetGlobalTestManager(), which
is declared here and defined by the conformance binary or by the
matchers' own unit test.