Fix VictoriaMetrics URL handling in alert history queries#6432
Open
evkuzin wants to merge 1 commit into
Open
Conversation
evkuzin
force-pushed
the
fix_victoriametrics
branch
2 times, most recently
from
9ffbed3 to
572116c
Compare
evkuzin
force-pushed
the
fix_victoriametrics
branch
from
572116c to
8d2e32c
Compare
Author
|
hm, no, wait. I need to handle path a bit better. Let me work on it a bit more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The alert history functionality was incorrectly constructing API URLs when using VictoriaMetrics generator URLs. VictoriaMetrics provides generator URLs with tenant-specific UI paths like:
The code was directly using these URLs as the base for Prometheus API client calls, resulting in malformed API endpoints:
❌ /select/0/vmui/api/v1/labels
❌ /select/0/vmui/api/v1/query_range
where the correct ones will be
✅ /select/0/prometheus/api/v1/labels
✅ /select/0/prometheus/api/v1/query_range
Solution
Enhanced the countAlerts function in alert_history.go to intelligently parse generator URLs and extract the correct API base URL
Added URL parsing logic to extract appropriate API base URLs from generator URLs
Added VictoriaMetrics-specific tenant path handling
Maintained backward compatibility for standard Prometheus deployments
Added debug logging to track URL transformations