Skip to content

steel egg#584

Open
JunkyDeveloper wants to merge 2 commits into
pterodactyl:mainfrom
JunkyDeveloper:steel
Open

steel egg#584
JunkyDeveloper wants to merge 2 commits into
pterodactyl:mainfrom
JunkyDeveloper:steel

Conversation

@JunkyDeveloper

Copy link
Copy Markdown

Description

Minecraft steel egg which resolves issue #583

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
    • If some script is needed then it is part of a current yolk or a PR to add one
  6. The egg was exported from the panel

@danny6167

Copy link
Copy Markdown
Member

Thanks for your submission.

I'm not seeing anything here that sets the port or any other configuration?

@JunkyDeveloper

Copy link
Copy Markdown
Author

I'm not seeing anything here that sets the port or any other configuration?

Thanks for the reply, I'm new to eggs :)
The port is in the default config, which will be generated on the first start. I plan to create the config and put the port there as a variable, but my problem is the config changes still to often because steel is still in beta.

What should I change?

@danny6167

Copy link
Copy Markdown
Member

We really need these eggs to support automatic configuration of the port.

What I would try is generating the smallest config file you can during the install.
Setup the eggs config parser to set the port in the config, and see if steel will just auto generate any of the missing entries on start.

We don't have a TOML parser, but you can use the file parser to match based on the beginning of the line. Try something like this.

"config/config.toml": {
  "parser": "file",
  "find": {
    "server_port": "server_port = {{server.build.default.port}}"
  }
}

@JunkyDeveloper

Copy link
Copy Markdown
Author

Thanks for your reply.
While writing my answer, I have an idea, to get the right config for the right version. Will try that thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants