Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions web/src/components/pages/project-create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,17 @@ export class ScionPageProjectCreate extends LitElement {
: nothing}

<div>
<div class="form-field">
<label for="name">Name</label>
<sl-input
id="name"
placeholder="my-project"
.value=${this.name}
@sl-input=${(e: Event) => this.onNameInput(e)}
required
></sl-input>
</div>
Comment on lines +618 to +627

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the Slug field is auto-derived from the Name field, separating them by moving Name to the top of the form while leaving Slug at the bottom (separated by dynamic workspace-specific fields) can lead to a disjointed user experience. Users won't easily see the auto-generated slug or be able to customize it adjacent to the name.\n\nConsider moving the Slug field to be directly below the Name field so they remain grouped together.\n\nNote: If you apply this suggestion, remember to also remove the original Slug field block from the bottom of the form (around line 810).

          <div class="form-field">
            <label for="name">Name</label>
            <sl-input
              id="name"
              placeholder="my-project"
              .value=${this.name}
              @sl-input=${(e: Event) => this.onNameInput(e)}
              required
            ></sl-input>
          </div>

          <div class="form-field">
            <label for="slug">Slug</label>
            <sl-input
              id="slug"
              placeholder="my-project"
              .value=${this.slug}
              @sl-input=${(e: Event) => this.onSlugInput(e)}
            ></sl-input>
            <div class="hint">URL-safe identifier. Auto-derived from name if left unchanged.</div>
          </div>


<div class="form-field">
<label for="mode">Workspace Type</label>
<sl-select
Expand Down Expand Up @@ -795,17 +806,6 @@ export class ScionPageProjectCreate extends LitElement {
`
: nothing}

<div class="form-field">
<label for="name">Name</label>
<sl-input
id="name"
placeholder="my-project"
.value=${this.name}
@sl-input=${(e: Event) => this.onNameInput(e)}
required
></sl-input>
</div>

<div class="form-field">
<label for="slug">Slug</label>
<sl-input
Expand Down
Loading