Fixes #310 Fix: apply invert filter to html instead of body - #621
Open
tarunashri6 wants to merge 1 commit into
Open
tarunashri6 wants to merge 1 commit into
tarunashri6 wants to merge 1 commit into
Conversation
Fixes publiclab#310 Fixes issue with incorrect dark mode rendering caused by applying invert filter on the body element. Changes made: - Removed invert filter from body - Applied invert filter to html element instead - Removed conflicting background styles This ensures consistent and correct UI rendering when toggling dark mode.
|
Thanks for opening this pull request! |
Author
|
Hi, I’ve implemented the fix by moving the invert filter to the html element and removing conflicting body styles. Please let me know if any changes are needed. Thanks! |
pydevsg
reviewed
Jun 23, 2026
pydevsg
left a comment
Member
There was a problem hiding this comment.
@tarunashri6 please add screenshot of the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310
Fixes issue with incorrect dark mode rendering caused by applying invert filter on the body element.
Changes made:
This ensures consistent and correct UI rendering when toggling dark mode.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!