Skip to content

Fixes #310 Fix: apply invert filter to html instead of body - #621

Open
tarunashri6 wants to merge 1 commit into
publiclab:mainfrom
tarunashri6:clean-final-fix
Open

tarunashri6 wants to merge 1 commit into
publiclab:mainfrom
tarunashri6:clean-final-fix

Conversation

@tarunashri6

Copy link
Copy Markdown

Fixes #310
Fixes issue with incorrect dark mode rendering caused by applying invert filter on the body element.

Changes made:

  • Removed invert filter from body
  • Applied invert filter to html element instead
  • Removed conflicting background styles

This ensures consistent and correct UI rendering when toggling dark mode.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

Fixes publiclab#310
 Fixes issue with incorrect dark mode rendering caused by applying invert filter on the body element.

Changes made:
- Removed invert filter from body
- Applied invert filter to html element instead
- Removed conflicting background styles

This ensures consistent and correct UI rendering when toggling dark mode.
@welcome

welcome Bot commented Apr 4, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@tarunashri6

Copy link
Copy Markdown
Author

Hi, I’ve implemented the fix by moving the invert filter to the html element and removing conflicting body styles. Please let me know if any changes are needed. Thanks!

@pydevsg pydevsg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunashri6 please add screenshot of the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invert button isn't making a dark background

2 participants