fix: preserve caret position in controlled custom fields#1647
Open
rinormhi wants to merge 1 commit into
Open
Conversation
|
@rinormhi is attempting to deploy a commit to the Puck Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1642
Description
This PR fixes a bug in Puck where controlled custom input fields would move the caret to the end on every keystroke while editing existing text.
The root cause was that
customfields read from the local field store, but their value was only reflected back after the asyncresolveComponentData -> replaceroundtrip completed. For controlled inputs, that delayed sync was enough to break normal browser caret preservation.This change keeps the existing update flow intact, but synchronizes the local field store immediately for
customand override-backed field types so controlled inputs can be edited in place as expected.Changes made
AutoFieldto synchronously mirror changes forcustomfield types into the local field store before forwardingonChange.How to test
<input>: