Avoid env command in facter plugin - #1687
Merged
Merged
Conversation
kajinamit
requested review from
a team,
alexjfisher and
bastelfreak
as code owners
September 20, 2025 02:22
kajinamit
force-pushed
the
fact-no-env
branch
from
November 24, 2025 16:45
5c28d02 to
c5955e9
Compare
bronachfalls
temporarily deployed
to
puppetcore-fork
July 31, 2026 11:06 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
bronachfalls
temporarily deployed
to
puppetcore-fork
August 3, 2026 08:58 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
bronachfalls
force-pushed
the
fact-no-env
branch
from
September 1, 2026 13:40
4fbd573 to
ecfeb3f
Compare
bronachfalls
approved these changes
Sep 1, 2026
... because it interferes with the capability of core facter utility to translate command to its full path. Also override of environment variables is not really necessary when 'mysqd' command is found in PATH. Signed-off-by: Takashi Kajinami <kajinamit@oss.nttdata.com>
bronachfalls
force-pushed
the
fact-no-env
branch
from
September 1, 2026 15:17
ecfeb3f to
e0e4110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Context
Summary
Avoid env command in facter plugin because it interferes with the capability of core facter utility to translate command to its full path.
Also override of environment variables is not really necessary when 'mysqd' command is found in PATH.
Related Issues (if any)
N/A
Checklist
puppet apply)