(CAT-2763) Fix Rakefile - #11
Merged
Merged
Conversation
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
The rspec-puppet-copy Rakefile broke `rake spec` (rspec-puppet isn't a dependency of this gem). Revert to the pre-regression Rakefile and add the one require actually needed to fix the original CI failure: the `release` job's `bundle exec rake build` had no `build` task because `bundler/gem_tasks` was never required. Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
releaseCI job failed withrake aborted! Don't know how to build task 'build'becauseRakefileneverrequiredbundler/gem_tasks, so Bundler'sbuild/install/releasetasks were never defined.Rakefilewith a verbatim copy ofrspec-puppet's ownRakefile. That brokerake specwithLoadError: cannot load such file -- rspec-puppet/tasks/release_test, sincepuppetlabs-syntaxis a plain Ruby gem (uses plainrspec) and doesn't depend onrspec-puppetat all — that file only exists to test the rspec-puppet gem itself.Rakefileto its pre-regression content and adds back only the one line actually needed:require 'bundler/gem_tasks'.Test plan
bundle exec rake build— buildspuppetlabs-syntax-7.2.1.gemintopkg/bundle exec rake spec— 44 examples, 0 failuresbundle exec rake rubocop— 15 files inspected, no offensesreleaseandspecjobs)Signed-off-by: Gavin Didrichsen gavin.didrichsen@gmail.com