ci: modernize GitHub Actions#9
Merged
Merged
Conversation
7a7996c to
20cb9ce
Compare
There was a problem hiding this comment.
Pull request overview
Modernizes the repository’s CI and maintenance automation by consolidating Go test/lint workflows into a single GitHub Actions pipeline, removing Travis, and aligning tests with stricter linting requirements.
Changes:
- Replace Travis + split GitHub Actions workflows with a single
.github/workflows/ci.ymlworkflow (tests + vet + race + golangci-lint). - Add Dependabot updates for Go modules and GitHub Actions; update README badge to the new CI workflow.
- Refactor test response writing to check write errors consistently via a shared
writeResponsehelper.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zips_test.go | Switch fixture writes to writeResponse helper. |
| transfers_test.go | Switch fixture writes to writeResponse helper. |
| friends_test.go | Switch fixture writes to writeResponse helper. |
| files_test.go | Switch fixture writes to writeResponse helper (also contains two updated JSON fixture lines). |
| events_test.go | Switch fixture writes to writeResponse helper. |
| account_test.go | Switch fixture writes to writeResponse helper. |
| client_test.go | Add writeResponse test helper (and import fmt). |
| README.md | Replace old workflow badges with a single CI badge. |
| .travis.yml | Remove legacy Travis CI configuration. |
| .github/workflows/golangci-lint.yml | Remove legacy lint workflow. |
| .github/workflows/go-test.yml | Remove legacy test workflow. |
| .github/workflows/ci.yml | Add consolidated CI workflow (tests/vet/race/lint). |
| .github/dependabot.yml | Add Dependabot configuration for gomod and GitHub Actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b628ad6 to
6a639ec
Compare
6a639ec to
69db964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
go.modtogo 1.17, matching the existinggolang.org/x/oauth2dependency floor.Client.Do(..., nil)before the timeout context is canceled.SetAll,Set, andDel, so the streaming fix does not leak response bodies.Risks
Complexity
Client.Dotimeout cleanup and the config methods that intentionally discard response bodies.Verification