Skip to content

Sanity checks free threading compatibility#119

Merged
joachimmetz merged 7 commits intopy4n6:mainfrom
greateggsgreg:sanity-checks-free-threading-compat
Apr 27, 2026
Merged

Sanity checks free threading compatibility#119
joachimmetz merged 7 commits intopy4n6:mainfrom
greateggsgreg:sanity-checks-free-threading-compat

Conversation

@greateggsgreg
Copy link
Copy Markdown
Contributor

This adds sanity checks for filesystem inputs based on static analysis and dynamic fuzzing.

Also add support for free-threaded Python

@joachimmetz
Copy link
Copy Markdown
Member

joachimmetz commented Apr 26, 2026

Thanks for the suggested changes, though it looks like there are some cross-platform compatibility issues

@greateggsgreg
Copy link
Copy Markdown
Contributor Author

greateggsgreg commented Apr 26, 2026

Thanks for the suggested changes, though it looks like there are some cross-platform compatibility issues

The mutex header includes ends up including limits.h, but our misc.h redefines min & max. These are almost certainly in modern platforms as we already have to require a C++14 compiler. Removed the redefinitions of min & max in misc.h.

Tested on local Linux machine (originally was developing on Windows) and works fine.

Copy link
Copy Markdown
Member

@joachimmetz joachimmetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joachimmetz joachimmetz merged commit 5510109 into py4n6:main Apr 27, 2026
8 checks passed
@greateggsgreg greateggsgreg deleted the sanity-checks-free-threading-compat branch April 30, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants