Skip to content

Conversation

@ramav87
Copy link
Contributor

@ramav87 ramav87 commented Dec 23, 2025

SidpyFitterRefactored Class - SidpyFitter had issues with graph creation (did not work for large datasets; exploded and failed). This refactored class solves that problem. But this will sit alongside the SidpyFitter until the features below are implemented/tested.

TODO:

  • make the output a sidpy dataset (it’s still dask),
  • and enable generation of a fit dataset,
  • Return covariances,
  • Add robust fit methods (adjust the existing objective fn)
  • Test on 2D fits

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 93.22034% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.10%. Comparing base (a289a80) to head (d2e4a60).

Files with missing lines Patch % Lines
sidpy/proc/fitter_refactor.py 90.54% 19 Missing ⚠️
tests/proc/fitter_function_utils.py 91.55% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   75.27%   76.10%   +0.83%     
==========================================
  Files          48       51       +3     
  Lines       10639    11108     +469     
==========================================
+ Hits         8008     8454     +446     
- Misses       2631     2654      +23     
Flag Coverage Δ
unittests 76.10% <93.22%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ramav87 ramav87 merged commit 8853256 into main Jan 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants