Adapt to upstream change in resampling with a Day frequency - #11547
Merged
spencerkclark merged 1 commit intoAug 30, 2026
Merged
Conversation
spencerkclark
commented
Aug 29, 2026
|
|
||
| def has_tick_resample_freq(freqs): | ||
| resample_freq, _ = freqs | ||
| _, resample_freq = freqs |
Member
Author
There was a problem hiding this comment.
This was previously inadvertently filtering on the initial_freq rather than the resample_freq...
By coincidence that happened to be OK given the set of frequency pairs that we were filtering and the pandas behavior at the time, but that is not the case anymore. This fixes that bug.
dcherian
approved these changes
Aug 30, 2026
Member
Author
|
Thanks for the quick review @dcherian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pandas is rolling back a change we adapted to about a year ago (#10650) related to resampling with a
Dayfrequency (pandas-dev/pandas#64793). This PR makes the necessary changes in xarray to do the same.This addresses some of the upstream failures surfaced in #11501.
Checklist
whats-new.rstAI Disclosure
This PR was created without AI.