Conversation
| valid_python_versions=valid_python_versions, | ||
| pypi_license_classifiers_list=pypi_license_classifiers_list, | ||
| pypi_license_classifier=pypi_license_classifier) | to_nice_yaml -}} |
There was a problem hiding this comment.
The reason for adding this is that the parameters with the “when”-attribute are not displayed to users AND are not stored in the .copier-answers.yml file. I would suggest adding them manually to the .copier-answers.yml file, as we may need them for future updates to the projects or for general maintenance.
This implementation should be valid and was taken from the Copier documentation.
There was a problem hiding this comment.
do we really need this parameters to reproduce the full build? especially the valid_python_versions parameter will change every year and can break build.
It is even desired, that if valid_python_versions is changed, the packages automatically add the new python version.
There was a problem hiding this comment.
That is a good point. I think you are right, and maybe we don't need them at all, since these are parameters that are always created from other parameters or from their default values. But now at least we know how we could store them if we wanted to.
h-chmeruk
force-pushed
the
add-copier_answers-file
branch
from
84f56d3 to
88e07c5
Compare
github-project-automation
bot
moved this from Require review
to Reviewer Approved
in Weekly Planning
2 participants
Which issue(s) are closed by this pull request?
Closes #33
Changes proposed in this pull request:
test_copier.pyfile to test the correct creation of the .copier-answers.yml file.