Skip to content

perf(metric): pre-apply cancel() before Simp.apply to fix SymPy 1.13 slowdown (#576) #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
utiberious wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

perf(metric): pre-apply cancel() before Simp.apply to fix SymPy 1.13 slowdown (#576) #591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4f48f7
perf(metric): pre-apply cancel() before Simp.apply in normalize_metri…
utiberious Apr 3, 2026
746fcab
fix(metric): remove cancel() from Christoffel_symbols to prevent form…
utiberious Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions galgebra/metric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from typing import List, Optional

from sympy import (
diff, trigsimp, Matrix, Rational,
cancel, diff, trigsimp, Matrix, Rational,
sqf_list, sqrt, eye, S, expand, Mul,
Add, simplify, Expr, Abs, Function, MatrixSymbol
)
Expand Down Expand Up @@ -609,9 +609,9 @@ def normalize_metric(self):
# Normalize derivatives of basis vectors
for x_i in self.n_range:
for jb in self.n_range:
self.de[x_i][jb] = Simp.apply((((self.de[x_i][jb].subs(renorm)
self.de[x_i][jb] = Simp.apply(cancel((self.de[x_i][jb].subs(renorm)
- diff(self.e_norm[jb], self.coords[x_i]) *
self.basis[jb]) / self.e_norm[jb])))
self.basis[jb]) / self.e_norm[jb]))
if self.debug:
printer.oprint('e^{i}->e^{i}/|e_{i}|', renorm)
for x_i in self.n_range:
Expand All @@ -621,7 +621,7 @@ def normalize_metric(self):
# Normalize metric tensor
for ib in self.n_range:
for jb in self.n_range:
self.g[ib, jb] = Simp.apply(self.g[ib, jb] / (self.e_norm[ib] * self.e_norm[jb]))
self.g[ib, jb] = Simp.apply(cancel(self.g[ib, jb] / (self.e_norm[ib] * self.e_norm[jb])))

if self.debug:
printer.oprint('renorm(g)', self.g)
Expand Down
Loading