Add browser push notification backend#589
Open
momocentral wants to merge 1 commit into
Open
Conversation
1cf0884 to
6531e9c
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
e7dc57b to
c2b22bd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 89.92% 90.22% +0.30%
==========================================
Files 55 59 +4
Lines 2451 2598 +147
==========================================
+ Hits 2204 2344 +140
- Misses 247 254 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8371f86 to
d4c144d
Compare
d4c144d to
14625fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds backend support for browser push notifications.
Implemented:
PushSubscriptionmodel, schemas, CRUD, and Alembic migrationpywebpush.env.exampleRequired deployment steps
After merging:
VAPID_PUBLIC_KEYVAPID_PRIVATE_KEYVAPID_SUBJECTPLATFORM_URLPUSH_NOTIFICATIONS_TTL_SECONDSVerification
I verified locally that:
push_subscriptionstable existspywebpushimports successfully