Skip to content

Remove Conda support#600

Merged
MateoLostanlen merged 2 commits into
mainfrom
codex/remove-conda-support
May 15, 2026
Merged

Remove Conda support#600
MateoLostanlen merged 2 commits into
mainfrom
codex/remove-conda-support

Conversation

@frgfm
Copy link
Copy Markdown
Member

@frgfm frgfm commented May 15, 2026

Summary

  • remove the Conda release and install-check jobs from the publish workflow
  • delete the client Conda recipe
  • remove Anaconda badges and Conda install instructions from the README and client docs

Context

This follows the packaging/tooling direction from #590, where the project moved to uv.

Checks

  • rg --hidden --no-ignore -n -i "conda|anaconda|miniconda|mamba|micromamba" client README.md .github
  • git diff --check
  • parsed .github/workflows/publish.yml with PyYAML

@frgfm frgfm force-pushed the codex/remove-conda-support branch from 4ffbddf to 0a4495e Compare May 15, 2026 11:20
@github-actions github-actions Bot added the topic: docs Improvements or additions to documentation label May 15, 2026
@frgfm frgfm marked this pull request as ready for review May 15, 2026 11:22
@frgfm frgfm requested a review from MateoLostanlen May 15, 2026 11:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (4309039) to head (8b9b31c).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
+ Coverage   90.09%   90.12%   +0.03%     
==========================================
  Files          55       55              
  Lines        2503     2512       +9     
==========================================
+ Hits         2255     2264       +9     
  Misses        248      248              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frgfm , thanks for the PR! Looks good to me, just 2 small tweaks to fully clean up Conda:

.pre-commit-config.yaml:8 — exclude: .conda was excluding client/.conda/meta.yaml (deleted in this PR) from the check-yaml hook. Dead config now, can be removed.
.gitignore:140 — client/conda-dist ignored the build-output dir created by the removed mkdir client/conda-dist workflow step. Nothing references it anymore, safe to drop.
Nothing blocking , just one extra commit to fully remove Conda

@frgfm
Copy link
Copy Markdown
Member Author

frgfm commented May 15, 2026

Addressed the remaining Conda cleanup from the review:

  • removed the obsolete .conda exclusion from .pre-commit-config.yaml
  • removed the obsolete client/conda-dist ignore entry from .gitignore
  • re-ran a full Conda/Anaconda/Mamba reference scan; no matches remain outside git metadata

Pushed in 8b9b31c.

@frgfm frgfm marked this pull request as draft May 15, 2026 12:50
@frgfm frgfm marked this pull request as ready for review May 15, 2026 12:54
@frgfm frgfm requested a review from MateoLostanlen May 15, 2026 12:54
Copy link
Copy Markdown
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@MateoLostanlen MateoLostanlen merged commit 5e4ffe1 into main May 15, 2026
23 checks passed
@MateoLostanlen MateoLostanlen deleted the codex/remove-conda-support branch May 15, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants