Skip to content

Refactor FSSH main class and Wigner sampling functions - #899

Open
felixmiaomiao wants to merge 3 commits into
pyscf:masterfrom
felixmiaomiao:master
Open

Refactor FSSH main class and Wigner sampling functions#899
felixmiaomiao wants to merge 3 commits into
pyscf:masterfrom
felixmiaomiao:master

Conversation

@felixmiaomiao

Copy link
Copy Markdown
Contributor

For the main FSSH class:

  1. Correct the calculation of the time-derivative coupling (TDC) for the κTDC method.
  2. Correct the final half-step velocity update after a successful surface hop.
  3. Improve screen output and trajectory writing.
  4. Refactor the main FSSH class:
  • Move independent numerical routines out of the class as pure functions.
  • Encapsulate repeated or self-contained logic into helper functions to simplify the main kernel() routine.

For the Wigner sampling functions:

  1. Add support for zero-temperature (T = 0 K) sampling.
  2. Add input validation and sanity checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant