fix(svelte): fix incorrect frontendDist path in svelte template
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISOR3X
approved these changes
Sep 15, 2025
Collaborator
|
Looks good to me, nice catch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered in #21: https://github.com/pytauri/create-pytauri-app/actions/runs/17697765693/job/50299377278?pr=21#step:15:119
Unlike Vue and React, Svelte doesn't follow Vite's
build.outDirconfiguration. Its output directory is specified byadapter-static, which defaults tobuildinstead ofdist. This caused build failures becausebuild.frontendDistintauri.conf.jsonwas set to../dist.In fact, create-tauri-app does specifically set
../buildasfrontendDistfor Svelte. However, for the existing architecture of create-pytauri-app, I don't want to create a special case forsvelteintemplates/./{{ project_name }}. So I chose to change the output directory insvelte.config.jstodist.CC @ISOR3X, since you are the author of the Svelte template.