Repository navigation
Write ESC as \u001b instead of the TOML 1.1-only \e escape - #641
Open
TheNetherWatcher wants to merge 1 commit into
Open
TheNetherWatcher wants to merge 1 commit into
TheNetherWatcher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the TOML 1.1 update (#456),
_escapedmapseto ESC, and_compact_escapesis derived from it, sodumps()now writes\x1bas\ein basic strings, multiline basic strings and quoted keys.\eis only valid in TOML 1.1, so the output can no longer be read by TOML 1.0 parsers such as the stdlibtomllib:This excludes
efrom the encode table only, so ESC is written as\u001b(valid in both 1.0 and 1.1), while the parser keeps accepting\e.Tests: dumping ESC in a value, a quoted key and a multiline string gives
\u001band round-trips; the output loads withtomllib(3.11+); parsing"\e"/"""\e"""still yields\x1b.Agent Drafting Metadata