Skip to content

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Dec 9, 2025

Summary:

  1. move model creation to a separate script, so it can be reused by future perf benchmarks
  2. move lm_eval call to shell script, which is simpler than calling it from a python subprocess
  3. simplify the for loop by moving the None baseline case inside the loop

Test Plan:

benchmarks/quantization/eval_accuracy_for_readme.sh

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Dec 9, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3470

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cf212a9 with merge base 2ae2994 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Dec 9, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 10d9979
ghstack-comment-id: 3632556050
Pull-Request: #3470
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2025
@vkuzo vkuzo added the topic: for developers Use this tag if this PR is mainly developer facing label Dec 9, 2025
[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Dec 9, 2025
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: d3ee49e
ghstack-comment-id: 3632556050
Pull-Request: #3470
@vkuzo vkuzo merged commit 37ab085 into main Dec 10, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants