Skip to content

Conversation

@RahulC7
Copy link
Contributor

@RahulC7 RahulC7 commented Dec 11, 2025

Summary:
Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations.

https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=384-396

Reviewed By: hsharma35

Differential Revision: D88895865

Summary:
Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations. 

https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=384-396

Reviewed By: hsharma35

Differential Revision: D88895865
Copilot AI review requested due to automatic review settings December 11, 2025 18:54
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16205

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit d6d5a52 with merge base 5033840 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 11, 2025

@RahulC7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88895865.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

RahulC7 added a commit to RahulC7/executorch that referenced this pull request Dec 11, 2025
Summary:

Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations. 

https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=384-396

Reviewed By: hsharma35

Differential Revision: D88895865
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage for CadenceWith16BitConvActivationsQuantizer, which was previously in the excluded quantizers list. The implementation validates that the quantizer correctly annotates both conv1d and conv2d operations with 16-bit activation quantization specs.

Key Changes:

  • Removed CadenceWith16BitConvActivationsQuantizer from the exclusion list
  • Added parameterized test cases for both conv1d and conv2d operations
  • Implemented graph builder helper methods following established patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant