Skip to content

Conversation

@RahulC7
Copy link
Contributor

@RahulC7 RahulC7 commented Dec 11, 2025

Summary:
Add annotation tests for CadenceWithSoftmaxQuantizer.

https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369

Reviewed By: hsharma35

Differential Revision: D88896712

Summary:

Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations. 

https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=384-396

Reviewed By: hsharma35

Differential Revision: D88895865
Copilot AI review requested due to automatic review settings December 11, 2025 18:56
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16206

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit de467ff with merge base 5033840 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 11, 2025

@RahulC7 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88896712.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage for CadenceWithSoftmaxQuantizer and CadenceWith16BitConvActivationsQuantizer by removing them from the exclusion list and adding corresponding annotation tests. The changes ensure all A16 (16-bit activation) quantizers have proper test coverage for their annotation behavior.

Key changes:

  • Removed CadenceWithSoftmaxQuantizer and CadenceWith16BitConvActivationsQuantizer from the excluded quantizers list
  • Added three new parameterized test cases for conv1d, conv2d, and softmax operations with A16 quantization
  • Implemented helper methods _build_conv1d_graph, _build_conv2d_graph, and _build_softmax_graph following the established testing pattern

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant