-
Notifications
You must be signed in to change notification settings - Fork 757
Adding test for CadenceWithSoftmaxQuantizer #16206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary: Add annotation tests for CadenceWith16BitConvActivationsQuantizer covering both conv1d and conv2d operations. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=384-396 Reviewed By: hsharma35 Differential Revision: D88895865
Summary: Add annotation tests for CadenceWithSoftmaxQuantizer. https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369 Reviewed By: hsharma35 Differential Revision: D88896712
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16206
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit de467ff with merge base 5033840 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive test coverage for CadenceWithSoftmaxQuantizer and CadenceWith16BitConvActivationsQuantizer by removing them from the exclusion list and adding corresponding annotation tests. The changes ensure all A16 (16-bit activation) quantizers have proper test coverage for their annotation behavior.
Key changes:
- Removed
CadenceWithSoftmaxQuantizerandCadenceWith16BitConvActivationsQuantizerfrom the excluded quantizers list - Added three new parameterized test cases for conv1d, conv2d, and softmax operations with A16 quantization
- Implemented helper methods
_build_conv1d_graph,_build_conv2d_graph, and_build_softmax_graphfollowing the established testing pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary:
Add annotation tests for CadenceWithSoftmaxQuantizer.
https://www.internalfb.com/code/fbsource/[01c566b03c670b1869136cbb64f25d16d730c8d4]/fbcode/executorch/backends/cadence/aot/quantizer/quantizer.py?lines=360-369
Reviewed By: hsharma35
Differential Revision: D88896712