Fix missing includes for C++23

[jgibson2]

Summary

Fixes some missing includes int the CoreML delegate that are necessary for C++23 projects.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16208

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit ea7315a with merge base 12d17ef ():

NEW FAILURES - The following jobs have failed:

• Apple / upload-frameworks-ios (gh)
  Error message: Cannot read properties of undefined (reading 'message')
• pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
  RuntimeError: Command docker exec -t 8033c63e7b402e95ff9e2fc94b2f92db4cc38fe56b3024d4b0c30800a232c793 /exec failed with exit code 92
• pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
  RuntimeError: Command docker exec -t 3ad927cb8cd3473bbbaecb0775c6b80a4a540b3cd40bcd51b8290d1f39629df3 /exec failed with exit code 92
• pull / test-lora-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 89f47d39ab1da49ad03a3785146c806ef9335fb85656b2a98191cf600e5380bb /exec failed with exit code 127
• trunk / unittest-release / macos / macos-job (gh)
  backends/xnnpack/test/ops/test_conv2d.py::TestConv2d::test_fp16_conv2d

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

• pull / android / run-emulator (gh) (#16137)
  Timeout waiting for emulator to boot.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[jgibson2]

@pytorchbot label "release notes: none"

[Copilot]

Pull request overview

This PR adds missing C++ standard library includes that are required for C++23 compatibility in the CoreML delegate. In C++23, certain standard library headers no longer transitively include other headers that were previously included automatically, requiring explicit includes.

• Adds #include <memory> for smart pointer support
• Adds #include <atomic> for atomic operations
• Adds #include <algorithm> for standard algorithms

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
backends/apple/coreml/runtime/kvstore/statement.hpp	Adds explicit <memory> include for smart pointer types
backends/apple/coreml/runtime/kvstore/key_value_store.hpp	Adds explicit <atomic> include for atomic types
backends/apple/coreml/runtime/delegate/multiarray.mm	Adds explicit <algorithm> include for standard algorithms
backends/apple/coreml/runtime/delegate/ETCoreMLAsset.mm	Adds explicit <memory> include for smart pointer types

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

C++ standard library headers should use #include instead of #import. While this may work in practice, #import is an Objective-C directive and #include is the correct directive for C++ standard headers. Change to #include <algorithm> for correctness.

Suggested change

	#import <algorithm>
	#include <algorithm>

[Copilot]

C++ standard library headers should use #include instead of #import. The #import directive is specific to Objective-C, while #include is the standard C++ directive. Change to #include <memory> for correctness.

Suggested change

	#import <memory>
	#include <memory>

[cccclai]

It seems like a reasonable review

[jgibson2]

Should I change all of these? A lot of the others are C++ libs that are #imported as well

[cccclai]

@shoumikhin @metascroy what do you think?

[jgibson2]

Any updates on this?

[cccclai]

Adding @metascroy for reviewing

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[metascroy]

LGTM, but let's test internal before landing (just imported). Generally we're very cautious to making runtime changes in December.

@cccclai I'm out starting tomorrow, can you check back on the internal tests and approve this PR if they pass.

[meta-codesync]

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D89220318.