Use default FakeTensorMode when calling module without input #16222
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, _ExportPassBase set self.tracer.fake_tensor_mode to a default value, but didn't use it when tracing. This caused operators that only have fake tensor implementations to crash. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I8d7ef0cc841b0e46cd04ea4ed941b761798a76d2
Erik-Lundell
requested review from
JacobSzwejbka,
digantdesai and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16222
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 6 Cancelled Jobs, 1 Unrelated FailureAs of commit 2da9794 with merge base d968e47 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
Collaborator
Author
|
It is hard for me to asses the side effects of this change but I think it makes sense. Can I get help getting the correct person to review this? @digantdesai |
| fake_tensor_mode = i.fake_mode | ||
| if fake_tensor_mode is None: | ||
| self.tracer.fake_tensor_mode = FakeTensorMode(allow_non_fake_inputs=True) | ||
| fake_tensor_mode = nullcontext() # type: ignore[assignment] |
Contributor
There was a problem hiding this comment.
@angelayi @tugsbayasgalan what is the difference between None and nullcontext() for fake tensor mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, _ExportPassBase set self.tracer.fake_tensor_mode to a default value, but didn't use it when tracing. This caused operators that only have fake tensor implementations to crash.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai