Skip to content

Conversation

@salmanmkc
Copy link

@salmanmkc salmanmkc commented Dec 13, 2025

Summary

Upgrade GitHub Actions to their latest versions for improved features, bug fixes, and security updates.

Changes

Action Old Version(s) New Version Release Files
aws-actions/configure-aws-credentials v1.7.0, v4 v5 Release android-release-artifacts.yml, apple.yml, cuda-perf.yml

Why upgrade?

Keeping GitHub Actions up to date ensures:

  • Security: Latest security patches and fixes
  • Features: Access to new functionality and improvements
  • Compatibility: Better support for current GitHub features
  • Performance: Optimizations and efficiency improvements

Security Note

Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.

Testing

These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.

Copilot AI review requested due to automatic review settings December 13, 2025 11:41
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16239

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 3626d07 with merge base c493e2d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the aws-actions/configure-aws-credentials GitHub Action from versions v1.7.0 and v4 to v5 across three workflow files. The upgrade ensures access to the latest security patches, features, and improvements while maintaining OIDC-based authentication for secure AWS access.

Key Changes:

  • Consistent upgrade of aws-actions/configure-aws-credentials to v5 across all workflow files
  • All OIDC authentication configurations (id-token permissions and role-to-assume) remain properly configured
  • No breaking changes to existing AWS authentication patterns

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/android-release-artifacts.yml Upgraded AWS credentials action from v1.7.0 to v5 for Android AAR upload workflow
.github/workflows/apple.yml Upgraded AWS credentials action from v1.7.0 to v5 for iOS frameworks upload workflow
.github/workflows/cuda-perf.yml Upgraded AWS credentials action from v4 to v5 for CUDA benchmark results upload workflow

Review Summary: The changes are straightforward version upgrades with no configuration changes needed. All workflows properly maintain OIDC authentication with the required id-token: write permissions and role-to-assume parameters. The upgrade is consistent across all affected files, and no instances of older versions remain in the codebase.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant