-
Notifications
You must be signed in to change notification settings - Fork 756
Upgrade GitHub Actions to latest versions #16239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade GitHub Actions to latest versions #16239
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16239
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 3626d07 with merge base c493e2d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the aws-actions/configure-aws-credentials GitHub Action from versions v1.7.0 and v4 to v5 across three workflow files. The upgrade ensures access to the latest security patches, features, and improvements while maintaining OIDC-based authentication for secure AWS access.
Key Changes:
- Consistent upgrade of
aws-actions/configure-aws-credentialsto v5 across all workflow files - All OIDC authentication configurations (id-token permissions and role-to-assume) remain properly configured
- No breaking changes to existing AWS authentication patterns
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/android-release-artifacts.yml |
Upgraded AWS credentials action from v1.7.0 to v5 for Android AAR upload workflow |
.github/workflows/apple.yml |
Upgraded AWS credentials action from v1.7.0 to v5 for iOS frameworks upload workflow |
.github/workflows/cuda-perf.yml |
Upgraded AWS credentials action from v4 to v5 for CUDA benchmark results upload workflow |
Review Summary: The changes are straightforward version upgrades with no configuration changes needed. All workflows properly maintain OIDC authentication with the required id-token: write permissions and role-to-assume parameters. The upgrade is consistent across all affected files, and no instances of older versions remain in the codebase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Upgrade GitHub Actions to their latest versions for improved features, bug fixes, and security updates.
Changes
aws-actions/configure-aws-credentialsv1.7.0,v4v5Why upgrade?
Keeping GitHub Actions up to date ensures:
Security Note
Actions that were previously pinned to commit SHAs remain pinned to SHAs (updated to the latest release SHA) to maintain the security benefits of immutable references.
Testing
These changes only affect CI/CD workflow configurations and should not impact application functionality. The workflows should be tested by running them on a branch before merging.