Mark skipped not working tests on MTIA #1260
Closed
+300
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enabling what is working now to run on MTIA. Enabling 231 test cases, where 485 test cases are not working, out of the total 716 tests. https://docs.google.com/spreadsheets/d/1TEW_QGTHO7pm_AyxNHMLB9-Cdlbpf9xPshLdtX-pqHI/edit?gid=800481755#gid=800481755 Differential Revision: D88862581
meta-cla
bot
added
the
CLA Signed
Myrthan
changed the title
oulgen
requested changes
Dec 13, 2025
Contributor
oulgen
left a comment
oulgen
left a comment
There was a problem hiding this comment.
marking 485 tests as skip does not feel sustainable, and also when we add new tests this will definitely break fbcode. Until you can pass more than say 80% of the tests, you should keep a sentinal file of passing tests instead, otherwise everyime we add a new test, we are gonna break fbcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enabling what is working now to run on MTIA.
Marking 485 test cases to be skip on MTIA.
Differential Revision: D88862581