Skip to content

Conversation

@bsprenger
Copy link
Contributor

@bsprenger bsprenger commented Dec 13, 2025

Description

This PR adds the TanhModuleConfig dataclass, which corresponds with the already-existing TanhModule. This PR also adds a test for the new config dataclass.

Motivation and Context

Adding this config dataclass will allow for directly instantiating a TanhModule, simply by defining the relevant fields in the config yaml.

Issue: #3256

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

This will allow configuration purely via config yaml files and the
hydra instantiate framework, allowing for better use in the trainer
system.
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3255

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant