Skip to content

Improve the loss_compare.sh logic #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fegin merged 4 commits into from
Dec 15, 2025
Merged

Improve the loss_compare.sh logic #2143

fegin merged 4 commits into from
Dec 15, 2025

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Dec 11, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

  1. Accept one "." (meaning the current commit) case to simplify the command line.
  2. Ignore the untracked files.

fegin added 2 commits December 11, 2025 12:43
@fegin
Update (base update)
102f342 
[ghstack-poisoned]
@fegin
Update
6a3fb65 
[ghstack-poisoned]
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 11, 2025
This was referenced Dec 11, 2025
Open
Open
fegin added 2 commits December 11, 2025 15:31
@fegin
Update (base update)
7b914cb 
[ghstack-poisoned]
@fegin
Update
ca0d42c 
[ghstack-poisoned]
wwwjn
wwwjn approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@wwwjn wwwjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fegin fegin changed the base branch from gh/fegin/52/base to main December 15, 2025 07:53
@fegin fegin merged commit c283a84 into main Dec 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wwwjn wwwjn wwwjn approved these changes

@tianyu-l tianyu-l Awaiting requested review from tianyu-l tianyu-l is a code owner

@wconstab wconstab Awaiting requested review from wconstab wconstab is a code owner

Assignees

No one assigned

Labels

ciflow/8gpu CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fegin @wwwjn