bugfix-Constants must be aligned #23
Open
kukrik wants to merge 1 commit intoqcubed:masterfrom
kukrik:master
Open
bugfix-Constants must be aligned #23kukrik wants to merge 1 commit intoqcubed:masterfrom kukrik:master
kukrik wants to merge 1 commit intoqcubed:masterfrom
kukrik:master
Conversation
…arams.php Please see there /application/src/Action/ActionParams.php lines 33 - 42!
Member
Author
|
If these constants are not corrected, then $this->strActiveItemId = $params->{ControlBase::ACTION_PARAM};or $this->strSelectedItemId = $params->{ControlBase::ACTION_PARAM};didn't work properly ... And these examples didn't work in the @spekary Bootstrap Nav and ListGroup class unless corrected these constants in the Controlbase class. This means that if a similar solution is needed in other developments, they would definitely not work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constants must be aligned with /application/src/Action/ActionParams.php
Please see there /application/src/Action/ActionParams.php lines 33 - 42!