show formatted json from errors in a separate dialog - #450
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No blocking issues were identified; the remaining test-coverage note is minor.
Review effort: Lite
Findings: None
What changed in this PR
Adds formatted JSON extraction and a dedicated dialog for viewing JSON embedded in error messages.
Changes:
- Extracts and tests embedded JSON objects and arrays.
- Adds a custom error snackbar with a “More info” action.
- Adds a shared store and globally mounted formatted-details dialog.
Review note: component coverage for the “More info” interaction remains a minor follow-up.
| File | Description |
|---|---|
src/lib/tests/extract-json-from-message.test.js |
Tests JSON extraction behavior. |
src/lib/extract-json-from-message.js |
Extracts embedded JSON objects and arrays. |
src/index.jsx |
Registers the custom error snackbar. |
src/components/ToastNotifications/ErrorSnackbar.jsx |
Displays shortened errors and the details action. |
src/components/ToastNotifications/ErrorDetailsDialog.jsx |
Displays formatted error details. |
src/components/ToastNotifications/error-details-store.js |
Shares selected error details with the dialog. |
src/App.jsx |
Mounts the error details dialog. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
trean
marked this pull request as ready for review
September 24, 2026 15:16
generall
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.