fix: coupling_matrix to support complex couplings - #40
Merged
Conversation
There was a problem hiding this comment.
Benchmark Results
Details
| Benchmark suite | Current: 402f1b7 | Previous: a1d1e7e | Ratio |
|---|---|---|---|
Correlations/two-time/single photon cavity |
144481248 ns |
151584403 ns |
0.95 |
Interaction Picture/coefficient matrix M/analytical (2 equal modes) |
10766 ns |
10737 ns |
1.00 |
Interaction Picture/coefficient matrix M/numerical (ODE) |
54081 ns |
55674 ns |
0.97 |
Interaction Picture/coupling matrix evaluation/2 modes |
82.84336099585062 ns |
92.19392033542977 ns |
0.90 |
Interaction Picture/coupling matrix evaluation/4 modes |
165.67525773195877 ns |
186.8048780487805 ns |
0.89 |
Interaction Picture/operator substitution/TLS cascade |
14782 ns |
15153 ns |
0.98 |
Pulse Couplings/multi-pulse/input 2 modes |
282898 ns |
282795 ns |
1.00 |
Pulse Couplings/multi-pulse/output 2 modes |
382980 ns |
378339 ns |
1.01 |
Pulse Couplings/single-pulse/input |
261576 ns |
262444 ns |
1.00 |
Pulse Couplings/single-pulse/input Gaussian |
74.07913669064749 ns |
85.847022587269 ns |
0.86 |
Pulse Couplings/single-pulse/output |
302818 ns |
303837 ns |
1.00 |
Pulse Couplings/single-pulse/output Gaussian |
74.07913669064749 ns |
91.02055498458377 ns |
0.81 |
SLH Algebra/closure evaluation/2-QD waveguide H(t) |
29534 ns |
30546 ns |
0.97 |
SLH Algebra/closure evaluation/2-QD waveguide L(t) |
2868.125 ns |
2977 ns |
0.96 |
SLH Algebra/numeric/2-QD waveguide composition |
24918 ns |
25047 ns |
0.99 |
SLH Algebra/symbolic/3-cavity cascade |
6129.4 ns |
6457.8 ns |
0.95 |
SLH Algebra/symbolic/concatenate + cascade |
1893.9 ns |
1949.9 ns |
0.97 |
SLH Algebra/symbolic/feedback OPO loop |
5348 ns |
5595 ns |
0.96 |
Translation/closure evaluation/3-cavity H(t) |
8084.75 ns |
8095.333333333333 ns |
1.00 |
Translation/closure evaluation/3-cavity L(t) |
7997 ns |
8215.666666666666 ns |
0.97 |
Translation/static/atom-cavity |
26740 ns |
26760 ns |
1.00 |
Translation/time-dependent/3-cavity H+L |
423361 ns |
426942 ns |
0.99 |
Translation/time-dependent/atom-cavity |
77958 ns |
81572 ns |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 96.77% 97.31% +0.54%
==========================================
Files 4 4
Lines 403 410 +7
==========================================
+ Hits 390 399 +9
+ Misses 13 11 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.