Skip to content

fix: coupling_matrix to support complex couplings - #40

Merged
oameye merged 1 commit into
mainfrom
complex-coupling
Aug 6, 2026
Merged

fix: coupling_matrix to support complex couplings#40
oameye merged 1 commit into
mainfrom
complex-coupling

Conversation

@oameye

@oameye oameye commented Aug 6, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark suite Current: 402f1b7 Previous: a1d1e7e Ratio
Correlations/two-time/single photon cavity 144481248 ns 151584403 ns 0.95
Interaction Picture/coefficient matrix M/analytical (2 equal modes) 10766 ns 10737 ns 1.00
Interaction Picture/coefficient matrix M/numerical (ODE) 54081 ns 55674 ns 0.97
Interaction Picture/coupling matrix evaluation/2 modes 82.84336099585062 ns 92.19392033542977 ns 0.90
Interaction Picture/coupling matrix evaluation/4 modes 165.67525773195877 ns 186.8048780487805 ns 0.89
Interaction Picture/operator substitution/TLS cascade 14782 ns 15153 ns 0.98
Pulse Couplings/multi-pulse/input 2 modes 282898 ns 282795 ns 1.00
Pulse Couplings/multi-pulse/output 2 modes 382980 ns 378339 ns 1.01
Pulse Couplings/single-pulse/input 261576 ns 262444 ns 1.00
Pulse Couplings/single-pulse/input Gaussian 74.07913669064749 ns 85.847022587269 ns 0.86
Pulse Couplings/single-pulse/output 302818 ns 303837 ns 1.00
Pulse Couplings/single-pulse/output Gaussian 74.07913669064749 ns 91.02055498458377 ns 0.81
SLH Algebra/closure evaluation/2-QD waveguide H(t) 29534 ns 30546 ns 0.97
SLH Algebra/closure evaluation/2-QD waveguide L(t) 2868.125 ns 2977 ns 0.96
SLH Algebra/numeric/2-QD waveguide composition 24918 ns 25047 ns 0.99
SLH Algebra/symbolic/3-cavity cascade 6129.4 ns 6457.8 ns 0.95
SLH Algebra/symbolic/concatenate + cascade 1893.9 ns 1949.9 ns 0.97
SLH Algebra/symbolic/feedback OPO loop 5348 ns 5595 ns 0.96
Translation/closure evaluation/3-cavity H(t) 8084.75 ns 8095.333333333333 ns 1.00
Translation/closure evaluation/3-cavity L(t) 7997 ns 8215.666666666666 ns 0.97
Translation/static/atom-cavity 26740 ns 26760 ns 1.00
Translation/time-dependent/3-cavity H+L 423361 ns 426942 ns 0.99
Translation/time-dependent/atom-cavity 77958 ns 81572 ns 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (a1d1e7e) to head (402f1b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   96.77%   97.31%   +0.54%     
==========================================
  Files           4        4              
  Lines         403      410       +7     
==========================================
+ Hits          390      399       +9     
+ Misses         13       11       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oameye
oameye merged commit dab446f into main Aug 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

coupling_matrix conjugates off-diagonal entries incorrectly for complex couplings

1 participant