Add benchmark smoke gate#528
Draft
heathsanchez wants to merge 2 commits into
Draft
Conversation
Author
|
Updated this draft after inspecting the failing The failure was from the pre-existing full AirspeedVelocity PR benchmark path, not from the new smoke runner. It runs the full benchmark suite on the PR and currently fails in: with: So I changed the existing Local verification still passes: This keeps PR CI focused on catching benchmark-suite bitrot without requiring every pull request to run the currently-failing full benchmark suite. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a lightweight benchmark smoke gate for the existing
benchmark/suite.This is intentionally narrow for the first step of #407:
benchmark/benchmarks.jlLocal verification
The smoke runner prints
BENCHMARK_SMOKE_OKon success.Scope
This PR does not attempt the full comparative benchmark report against QuTiP / QuantumToolbox.jl yet. It is meant to establish the small PR-safe CI gate first, so the benchmark suite stops silently bitrotting.