Skip to content

feature/file upload - #160

Open
Dustin Pham (DustinPham) wants to merge 27 commits into
mainfrom
feature/file-upload
Open

feature/file upload#160
Dustin Pham (DustinPham) wants to merge 27 commits into
mainfrom
feature/file-upload

Conversation

@DustinPham

@DustinPham Dustin Pham (DustinPham) commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

implementation of file upload in angular and react

TODO:

  • Add code connect for React
  • Update code connect when figma is ready for dev

@DustinPham
Dustin Pham (DustinPham) force-pushed the feature/file-upload branch 7 times, most recently from 0ad1d99 to f2e167e Compare February 10, 2026 04:10
@DustinPham
(feat) Add file-upload machine and types/utilities for files
22b605b 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
Adding file-upload.api.ts
f8eb90f 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
Fixing some types
ea63283 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
Adding file upload to qds-core and angular-core + fix react-core bad …
05a40f0 
…import

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
adding angular functionality and demos
49a9d88 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
md default size, add more styling to match figma, fix composite funct…
1518fa5 
…ionality to hide dropzone and replace with item group

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
update file-upload component, fix css for sm,md,lg sizes
2e3f67d 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
fix error message in item not displaying right size, fix error icon n…
e36e309 
…ot showing and being wrong size

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
cleanup css, add size demo, add rejected files to composite demo, cha…
95cf25d 
…nge file icon to layers

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
Fixing type docs, cleanup file upload size demo
01ff011 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
Change file-upload api back to onInput as onChange causes infinite lo…
0b444e0 
…op in react implementation

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
initial stopping point for react file-upload implementation
e82b06a 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
Adding error text as directive, fix error messages not showing, add e…
94c2002 
…rror demo for angular

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
add required styling, update jsdocs, add additional format for errorT…
10c39d2 
…ext demo, remove duped doc content

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
feat: finish implementation of file upload for both angular and react
a36eb6d 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
fix linting
8107e69 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
add license info for file-upload
b5d1186 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
remove unnecessary changes
206f190 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
fix: address critical issues in file-upload component
a9e4c46 
  - Fix data-invalid attribute using wrong property (disabled -> invalid)
  - Add lastModified to file equality check for better duplicate detection
  - Fix memory leak by properly unsubscribing from fileChanged output
  - Remove duplicate IconDirective import in module

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
change getFileErrorMessage to util to reuse
e30422c 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
fix lint
dc32778 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
fix lint(2)
827e302 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
add warn for catch in setInputFiles and remove computed from trackBin…
8238b62 
…dings

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
add catch for dropzone handling
ba15588 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
add disabled demos and update error demo to also showcase max size
26c98a4 
Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
fix(file-upload): add syncRead as bindable parameter to fix stale onF…
26551de 
…ileChange callback data

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@DustinPham
add figma code connect for file-upload (will need to update when actu…
660bc57 
…ally marked ready for dev)

Signed-off-by: Dustin Pham <dustinpham95@gmail.com>
@R-Bower Ryan Bower (R-Bower) added Waiting on Design Indicates that the task is dependent on in-progress work from the design team and removed Waiting on Design Indicates that the task is dependent on in-progress work from the design team labels Mar 30, 2026
@github-actions

github-actions Bot commented May 30, 2026

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. To prevent automatic closure in 10 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

@github-actions github-actions Bot added the Stale label May 30, 2026
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. To prevent automatic closure in 10 days, remove the stale label or add a comment. You can reopen a closed pull request at any time.

@github-actions github-actions Bot added the Stale label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@R-Bower Ryan Bower (R-Bower) Awaiting requested review from R-Bower R-Bower is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Waiting on Design Indicates that the task is dependent on in-progress work from the design team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DustinPham @R-Bower