Skip to content

First blog about test classloading changes - #2287

Merged
cescoffier merged 1 commit into
quarkusio:mainfrom
holly-cummins:test-classloading-blog
Apr 30, 2025
Merged

First blog about test classloading changes#2287
cescoffier merged 1 commit into
quarkusio:mainfrom
holly-cummins:test-classloading-blog

Conversation

@holly-cummins

Copy link
Copy Markdown
Contributor

I've added a blog discussing the externals of the test classloading change.

I was also hoping to discuss the internals, but that's harder so I kept putting it off. We ought to publish something alongside 3.22, so I've run out of runway to write an epic blog. The discussion of internals should maybe be in its own blog, which gives more time to get "part ii - the terrifying internals" written and out.

@holly-cummins holly-cummins changed the title Add test classloading blog First blog about test classloading changes Apr 22, 2025
@github-actions

github-actions Bot commented Apr 22, 2025

Copy link
Copy Markdown

🙈 The PR is closed and the preview is expired.

@cescoffier cescoffier moved this from Todo to In Progress in WG - Test classloading Apr 23, 2025
@cescoffier cescoffier self-assigned this Apr 23, 2025
@cescoffier
cescoffier self-requested a review April 23, 2025 05:25
@cescoffier cescoffier removed their assignment Apr 23, 2025
@holly-cummins

Copy link
Copy Markdown
Contributor Author

Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc

@maxandersen maxandersen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good write up - added a few clarifying suggestions but good stuff!

@cescoffier cescoffier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I added a few comments, nothing serious.

Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc Outdated
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
Comment thread _posts/2025-04-22-test-classloading-rewrite.adoc
@holly-cummins
holly-cummins force-pushed the test-classloading-blog branch from 14e0126 to 310f649 Compare April 24, 2025 08:53
@holly-cummins

Copy link
Copy Markdown
Contributor Author

I think I've done all your suggestions, @cescoffier, except the rework of that introductory paragraph, where I can't come up with something that flows well. I didn't do an admonition for augmentation, just a link, because I didn't want to interrupt the bulleted flow.

Here it is with the admonition, but I think it distracts from the more important content. WDYT, @cescoffier?
image

@cescoffier

Copy link
Copy Markdown
Member

Agreed, the admonition is too prominent. It's where I would love to have "side notes" - link it is.

@maxandersen

Copy link
Copy Markdown
Member

mark as approved based on the issues i commented on is fixed. let you decide when to merge after admonition fixed.

@holly-cummins
holly-cummins force-pushed the test-classloading-blog branch from 8aa2d09 to b3a7ef7 Compare April 24, 2025 14:32
@holly-cummins

Copy link
Copy Markdown
Contributor Author

I've removed the admonition and squashed. I don't know if it's best to put this out to coincide with 3.22 (yesterday) or 3.22 platform (next week).

@cescoffier cescoffier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I would postpone the publication after the 3.22 platform release announcement, maybe just after it. But, no strong opinion.

@holly-cummins
holly-cummins force-pushed the test-classloading-blog branch from b3a7ef7 to a57c99e Compare April 29, 2025 17:14
@holly-cummins

Copy link
Copy Markdown
Contributor Author

I've adjusted the date and squashed, so we should be good to merge tomorrow. I've had one zulip message reporting the dev services startup sequence change already, so we should not delay past tomorrow, I think.

@cescoffier
cescoffier merged commit 88e7876 into quarkusio:main Apr 30, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in WG - Test classloading Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants