Test/fragment anchor validation - #2713
Draft
holly-cummins wants to merge 2 commits into
Draft
Conversation
holly-cummins
marked this pull request as draft
June 12, 2026 10:42
holly-cummins
force-pushed
the
test/fragment-anchor-validation
branch
from
July 10, 2026 11:24
020721c to
9a0056d
Compare
|
🎊 PR Preview 35958d8 has been successfully built and deployed to https://quarkus-website-pr-2713-preview.surge.sh
|
holly-cummins
force-pushed
the
test/fragment-anchor-validation
branch
from
July 10, 2026 13:13
9a0056d to
1fb2d92
Compare
holly-cummins
force-pushed
the
test/fragment-anchor-validation
branch
2 times, most recently
from
July 17, 2026 09:20
27a32cb to
108d7c5
Compare
Contributor
Author
|
Needs quarkusio/quarkus#55413 to make it into a release, so maybe it shouldn't be checking the latest pages, only |
holly-cummins
force-pushed
the
test/fragment-anchor-validation
branch
from
July 24, 2026 16:29
108d7c5 to
0a1a3bf
Compare
Contributor
Author
|
Should be good to merge once 3.38 is out. |
Compare the built site against the gh-pages branch to find changed HTML files. When 15 or fewer pages changed and no build infrastructure files were modified, run the link crawler only on those pages (depth-1 check). This avoids a full-site crawl on small PRs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> # Conflicts: # .github/workflows/build.yml # src/test/java/io/quarkusio/LinkCrawlerTest.java
Crawls internal pages and verifies that #fragment targets exist as element IDs on the destination page. Uses the same test.crawl.* properties as LinkCrawlerTest so both tests share the same Maven command line, including incremental mode from changed-paths. Instead of a separate test class with its own BFS crawl (which only covered 57 of 128 pages due to a URL resolution bug), fragment anchors are now collected during the existing multi-threaded crawl and verified in a single pass afterward. Also fixes a duplicated incremental-mode check in crawLoop. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
holly-cummins
force-pushed
the
test/fragment-anchor-validation
branch
from
August 3, 2026 10:17
0a1a3bf to
3fd00ae
Compare
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking as draft, because this is red! Which is good!
I mean, it's bad that it's red, but it's found problems that need fixing before it can merge. This tests #anchor in pages, rather than just the top level page. Bad anchors won't cause a 404, but they're sloppy – and easy to get wrong. (I'm surprised our adoc doesn't pick them, is there a strictness setting we need to be changing?)